Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pypy pypy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 698
    • Issues 698
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PyPyPyPy
  • pypypypy
  • Merge requests
  • !191

Pure-Python SHA implementation is confused

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Bitbucket Importer requested to merge bitbucket/merged-pr-191 into branch/default Sep 28, 2013
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 1

Created originally on Bitbucket by lvh (Laurens Van Houtven)

Was already merged in Bitbucket before import, marked as merged by the import user

  1. A docstring claims to be MD5.
  2. The block_size constant is wrong.

This is being sent to "default". Is that okay? I don't know how to bitbucket.

There's an API bug as well. You're supposed to be able to call it as sha(some_message).digest(), but this implementation doesn't support that, so you have to do h = sha(); h.update(some_message); h.digest(). I guess that should be another pull request.

There should be tests for this, but I can't figure out where to put them. It seems few people care about this because they usually get the OpenSSL backed implementation.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bitbucket/merged-pr-191