Pure-Python SHA implementation is confused

Merged Bitbucket Importer requested to merge bitbucket/merged-pr-191 into branch/default

Created originally on Bitbucket by lvh (Laurens Van Houtven)

Was already merged in Bitbucket before import, marked as merged by the import user

  1. A docstring claims to be MD5.
  2. The block_size constant is wrong.

This is being sent to "default". Is that okay? I don't know how to bitbucket.

There's an API bug as well. You're supposed to be able to call it as sha(some_message).digest(), but this implementation doesn't support that, so you have to do h = sha(); h.update(some_message); h.digest(). I guess that should be another pull request.

There should be tests for this, but I can't figure out where to put them. It seems few people care about this because they usually get the OpenSSL backed implementation.

Merge request reports