Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pypy pypy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 696
    • Issues 696
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to a massive storm of spam, registration on this instance now requires explicit administrator approval. Sorry for the added friction, we're also looking into automatic filtering options.

  • PyPyPyPy
  • pypypypy
  • Merge requests
  • !367

Default

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Bitbucket Importer requested to merge bitbucket/declined-pr-367 into branch/default Dec 13, 2015
  • Overview 6
  • Commits 0
  • Pipelines 0
  • Changes -

Created originally on Bitbucket by vincentlegoll (Vincent Legoll)

Changesets for this Pull Request have not been imported, because it had been already declined on Bitbucket. Marked as closed by the import user.

Fix for Issue #2198 + two additional patches

Split into small logical steps, as requested by Ronan

  • Remove stale comment

    Ronan Lamy thinks this comment is obsolete (c.f. #2198) Remove it so that newcomers don't start to work on it.

  • Avoid unnecessary work in switch_to_correct_strategy

  • Add an assertion on step being non null in setslice()

  • Remove stale comments in setslice()

  • Move common code outside of conditional

  • Add comment explaining one case

  • Add shotrcut when there's nothing to do: replace empty slice with empty iterable

  • Assign the slice instead of copying elem by elem

  • Handle assigning bigger lists to slice case

  • Remove now unused code

  • Handle assigning same size lists to slice case

  • Factorize delta < 0 and delta == 0 cases with now identical code

  • Handle assigning smaller lists to slice case

  • Factorize common code

  • Describe branch

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bitbucket/declined-pr-367