Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pypy pypy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 676
    • Issues 676
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

April 05-07 - Mercurial Paris Conference 2023 - One day of workshop dedicated to Heptapod and Mercurial usage and workflow. There are still places available for both workshops and talks!

  • PyPyPyPy
  • pypypypy
  • Merge requests
  • !688

Py3.7 time module minor BPOs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bitbucket Importer requested to merge branch/py3.7-time-minor-bpos into branch/py3.7 Dec 29, 2019
  • Overview 0
  • Commits 5
  • Pipelines 0
  • Changes 4

Created originally on Bitbucket by Yannick_Jadoul (Yannick Jadoul)

Implemented the changes from 4 smaller bugs.python.org issues/PRs that should fix last few failing test_time tests on Python 3.7.

See

  • https://bugs.python.org/issue31803 & https://github.com/python/cpython/pull/4020
  • https://bugs.python.org/issue13312 & https://github.com/python/cpython/pull/8912
  • https://bugs.python.org/issue31917 & https://github.com/python/cpython/pull/4207
  • https://bugs.python.org/issue32025 & https://github.com/python/cpython/pull/4410

‌

Remarks/things to be checked:

  • CPython’s source checks CLOCK_PROCESS_CPUTIME_ID (see https://github.com/python/cpython/blob/3.7/Modules/timemodule.c#L1328), but uses CLOCK_THREAD_CPUTIME_ID. I don’t know if these two identifiers are somehow linked, or whether that’s a copy-paste error.
  • I’ve not tested these changes on Windows/macOS, so we should keep an eye on the buildbots, after.

‌

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: branch/py3.7-time-minor-bpos