Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pypy pypy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 676
    • Issues 676
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

April 05-07 - Mercurial Paris Conference 2023 - One day of workshop dedicated to Heptapod and Mercurial usage and workflow. There are still places available for both workshops and talks!

  • PyPyPyPy
  • pypypypy
  • Merge requests
  • !748

simple fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Matti Picus requested to merge topic/hpy-update-vendored/hpy-update-vendored-fixes into branch/hpy-update-vendored Aug 13, 2020
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 2

Some simple fixes from trying a translation. It now gets to compilation but errors because HPyDef_Slot is undefined:

pypy_module__cffi_backend.c: In function ‘pypy_g_W_FFIObject_fetch_int_constant’:
pypy_module__cffi_backend.c:65474:13: warning: assignment discards ‘const’ qualifier \
    from pointer target type [-Wdiscarded-qualifiers]
65474 |   l_v552129 = RPyField(l_v552128, globals);
      |             ^
pypy_module__hpy_universal.c: In function ‘pypy_g_HPyModule_Create’:
pypy_module__hpy_universal.c:33729:12: warning: assignment to ‘int *’ \
    from incompatible pointer type ‘cpy_PyMethodDef *’ {aka ‘struct PyMethodDef *’} \
    [-Wincompatible-pointer-types]
33729 |  l_v667359 = RPyField(l_hpydef_1, legacy_methods);
      |            ^
pypy_module__hpy_universal.c: In function ‘pypy_g_HPyType_FromSpec’:
pypy_module__hpy_universal.c:38223:2: error: unknown type name ‘HPyDef_Slot’; \
    did you mean ‘HPyDef_SLOT’?
38223 |  HPyDef_Slot *l_v669297; Signed l_v669092; Signed l_v669096;
      |  ^~~~~~~~~~~
      |  HPyDef_SLOT
pypy_module__hpy_universal.c:39238:17: error: ‘HPyDef_Slot’ undeclared \
    (first use in this function); did you mean ‘HPyDef_SLOT’?
39238 |    l_v669297 = (HPyDef_Slot *)(l_v669296);
      |                 ^~~~~~~~~~~
      |                 HPyDef_SLOT
pypy_module__hpy_universal.c:39238:17: note: each undeclared identifier is reported \
     only once for each function it appears in
pypy_module__hpy_universal.c:39238:30: error: expected expression before ‘)’ token
39238 |    l_v669297 = (HPyDef_Slot *)(l_v669296);
      |                              ^
In file included from /home/matti/pypy_stuff/pypy/rpython/translator/c/src/g_include.h:11,
                 from pypy_module__hpy_universal.c:9:
/home/matti/pypy_stuff/pypy/rpython/translator/c/src/support.h:66:52: error: request \
    for member ‘slot’ in something not a structure or union
   66 | #  define RPyField(ptr, name)                ((ptr)->name)
      |                                                    ^~
/home/matti/pypy_stuff/pypy/rpython/translator/c/src/support.h:66:52: \
    note: in definition of macro ‘RPyField’
   66 | #  define RPyField(ptr, name)                ((ptr)->name)
      |                                                    ^~
make: *** [Makefile:915: pypy_module__hpy_universal.o] Error 1

Here is the complete compilation output, we should clean up those warnings https://paste.ubuntu.com/p/hK9s4mbwMy/

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: topic/hpy-update-vendored/hpy-update-vendored-fixes