Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pypy pypy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 673
    • Issues 673
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PyPy
  • pypypypy
  • Merge requests
  • !758

Set and save MACOSX_DEPLOYMENT_TARGET during translation (2.7)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Dan Villiom Podlaski Christiansen requested to merge topic/default/macosx-deployment-target-2.7 into branch/default Sep 22, 2020
  • Overview 0
  • Commits 3
  • Pipelines 2
  • Changes 6

MACOSX_DEPLOYMENT_TARGET specifies which OS version to target. It is commonly set using an environment variable, so I added the ability to do so for the translation options. The default is unchanged, but the MacPorts port always sets this to the current OS, so this should allow me to remove some patches from it.

One benefit of specifying this in the translation options is that tests shouldn't be affected by it, ensuring maximum coverage.

The clock_gettime() function was added in macOS 10.12, but forcibly disabled in PyPy. Now that we can rely on checks actually detecting which OS to target, I adjusted the check to reject it when targeting 10.7. This also provides a good canary check; if the function is present in products from the buildbot, this branch doesn't work.

Edited Sep 27, 2020 by Dan Villiom Podlaski Christiansen
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: topic/default/macosx-deployment-target-2.7