Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pypy pypy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 674
    • Issues 674
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PyPyPyPy
  • pypypypy
  • Merge requests
  • !769

Change parameter type of PyModule_New to const char*, and use build_type_checkers to define PyModule_Check and PyModule_CheckExact

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Yannick Jadoul requested to merge branch/pymodule_new-const-charp into branch/default Oct 18, 2020
  • Overview 7
  • Commits 4
  • Pipelines 2
  • Changes 4
  • Bumped into the mismatched parameter type of PyModule_New in https://github.com/pybind/pybind11/pull/2551. See https://docs.python.org/2/c-api/module.html#c.PyModule_New.

  • PyModule_CheckExact was also still missing, so while making changes, I added this one as well.

  • Test pypy/module/cpyext/test/test_cpyext.py::TestApi::test_signature failed using build_type_checkers to create PyModule_Check and PyModule_CheckExact, so I changed the signature's void * to PyObject *, as all Py..._Check and Py..._CheckExact are defined in the CPython docs as functions taking a PyObject * (even most/all of them are actually macros?). See e.g. https://docs.python.org/2/c-api/set.html#c.PySet_Check.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: branch/pymodule_new-const-charp