Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pypy pypy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 676
    • Issues 676
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PyPyPyPy
  • pypypypy
  • Merge requests
  • !784

CPyext: Implement METH_FASTCALL

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sebastian Berg requested to merge branch/meth-fastcall into branch/py3.7 Dec 10, 2020
  • Overview 16
  • Commits 7
  • Pipelines 4
  • Changes 7

This commit adds the METH_FASTCALL method calling convention (with the exception of omitting the const classifier for the arguments). Beginning with Python 3.10, METH_FASTCALL is not part of the limited API anymore, it was first available (although undocumented) in Python 3.7.

Closes #3357 (closed)

--HG-- branch : meth-fastcall


I Am not 100% sure about the reference counting, I assume the decref is only needed for the tuple that is created using PyTuple_New and the rest "just works". I seem to recall that the const classifier is tricky in PyPy (I could not figure it out), so I assumed it is OK to drop it?

Just opening in case you are happy with it, not sure if it quite hits the mark with how one tuple is created using the string and the other not, etc.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: branch/meth-fastcall