Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pypy pypy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 673
    • Issues 673
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PyPy
  • pypypypy
  • Merge requests
  • !790

Branch/py3 7 mp queue close fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Alex Orange requested to merge branch/py3_7_mp_queue_close_fix into branch/py3.7 Jan 01, 2021
  • Overview 6
  • Commits 2
  • Pipelines 2
  • Changes 2

This fixes #3372.

In short:

  • Current CPython multiprocessing.queues.Queue doesn't close properly unless put has been called before you try to close.
  • Not as simple as just changing the write pipe close as this has to be done in the context of the buffer thread.
  • This makes sure that before the thread has been started (before put has been called for instance) that something will close the write pipe.
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: branch/py3_7_mp_queue_close_fix