Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pypy pypy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 697
    • Issues 697
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to a massive storm of spam, registration on this instance now requires explicit administrator approval. Sorry for the added friction, we're also looking into automatic filtering options.

  • PyPyPyPy
  • pypypypy
  • Merge requests
  • !815

Fix a bug in objspace.fake.checkmodule which was introduced 5 years ago by 2acc241fc909

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Antonio Cuni requested to merge branch/fix-checkmodule into branch/default Apr 11, 2021
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 2

The call to module.init() causes module.startup() to be called at translation-time and sets module.startup_called = True. The net effect is that we freeze values which are supposed to be computed at runtime, and this e.g. causes problems to HPy.

The original commit added the call to module.init() to be able to ztranslate _multiprocessing: fix it differently by moving the relevant code to startup().

Buildbots (in-progress at the moment of writing):

  • own-linux-x86-64
  • pypy-c-jit-linux-x86-64
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: branch/fix-checkmodule