Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pypy pypy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 677
    • Issues 677
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PyPyPyPy
  • pypypypy
  • Merge requests
  • !816

Fix a bug in objspace.fake.checkmodule which was introduced 5 years ago by 2acc241fc909

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Antonio Cuni requested to merge branch/fix-checkmodule-2 into branch/default Apr 11, 2021
  • Overview 1
  • Commits 2
  • Pipelines 2
  • Changes 3

The call to module.init() causes module.startup() to be called at translation-time and sets module.startup_called = True. The net effect is that we freeze values which are supposed to be computed at runtime, and this e.g. causes problems to HPy.

The original commit added the call to module.init() to be able to ztranslate _multiprocessing: fix it differently by moving the relevant code to startup().

These buildots are passing:

  • own-linux-64
  • pypy-c-jit-linux-x86-64
Edited Apr 11, 2021 by Antonio Cuni
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: branch/fix-checkmodule-2