Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pypy pypy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 698
    • Issues 698
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PyPyPyPy
  • pypypypy
  • Merge requests
  • !819

Add special error messange for '\0' in rstruct.formatiterator for bpo-35714

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Ondrej Baranovič requested to merge branch/bpo-35714 into branch/default May 02, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2

Passing the NUL character in a struct format string was undefined behaviour in CPython. PyPy handles it correctly, but the CPython fix introduced a different error message that is causing failures in lib-python.3.test.test_struct, which will be fixed by this PR. Because the error message is coming from RPython, this PR changes it in both PyPy2 and PyPy3, even though it was not fixed for CPython2.

https://bugs.python.org/issue35714, https://github.com/python/cpython/pull/16928/files

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: branch/bpo-35714