Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pypy pypy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 673
    • Issues 673
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PyPy
  • pypypypy
  • Merge requests
  • !837

build_cffi_imports: fix determining CFLAGS

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dan Villiom Podlaski Christiansen requested to merge branch/py3.8-fix-cflags into branch/py3.8 Oct 05, 2021
  • Overview 5
  • Commits 1
  • Pipelines 1
  • Changes 1

The previous logic implicitly assumed that CFLAGS was either unset or started with a space, breaking the MacPorts build. In addition, it also extracted the version info from the running interpreter rather than the built one.

I ran into this when trying to package the release candidate of 3.8 for MacPorts, which sets CFLAGS during the build.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: branch/py3.8-fix-cflags