Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pypy pypy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 673
    • Issues 673
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PyPy
  • pypypypy
  • Merge requests
  • !845

Fix NFA generation in metaparser for grammar rules of form "foo: [a* b]"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ondrej Baranovič requested to merge branch/metaparser-optional-repeater into branch/default May 12, 2022
  • Overview 2
  • Commits 2
  • Pipelines 1
  • Changes 2

I have spent the past few months writing a Lua interpreter in RPython. (While I haven't implemented the full standard library yet, the benchmarks I have run are quite impressive.)

While implementing the parser, I noticed that the LL(1) PyPy parser generator generates an invalid NFA for grammar rules of the form foo: [hello* world]. Instead, the generated NFA corresponds to foo: [hello*] [world]. This MR fixes the NFA generation.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: branch/metaparser-optional-repeater