Skip to content
Snippets Groups Projects

Do not mix string and float values to sort domain

Merged Maxime Richez requested to merge topic/default/sort-domain into branch/default

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas Évrard requested review from @nicoe

    requested review from @nicoe

  • Maxime Richez resolved all threads

    resolved all threads

  • Maxime Richez added 1 commit

    added 1 commit

    • 7b3e7bb01570 - Do not mix string and float values to sort domain

    Compare with previous version

  • Cédric Krier
  • trytond and sao must also be updated.

  • It will be good to have a test.

  • unassigned @maxx

  • Cédric Krier added 1 commit

    added 1 commit

    • ac7ac431cb97 - Compare leaf values only of the same type to sort domain

    Compare with previous version

  • assigned to @ced

  • Cédric Krier resolved all threads

    resolved all threads

  • added sao label

  • added trytond label

  • As Javascript Array.sort use the string version of the object to sort. It is not possible to have null value first like in Python. I do not think it is a major issue as domain comparison is normally done in the same platform.

  • Author Developer

    LGTM for GTK

  • Cédric Krier added 43 commits

    added 43 commits

    Compare with previous version

  • Cédric Krier enabled an automatic merge when the pipeline for cb0f2181f618 succeeds

    enabled an automatic merge when the pipeline for cb0f2181f618 succeeds

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading