Skip to content
  • Gregory Szorc's avatar
    wireproto: convert legacy commands to command executor · cc8c06835097
    Gregory Szorc authored
    Calls to the legacy commands "changegroup" and "changegroupsubset" have
    been ported to the new command executor interface.
    
    Because we always pass arguments by name and not position, some
    inconsistent names throughout the code base have been unified.
    
    As part of this change, we no longer had any remaining callers
    of the legacy command methods {between, branches, changegroup,
    changegroupsubset}. So, these interfaces/methods have been dropped
    from peer interfaces. We still have an interface declaring these
    methods. But that interface is implemented on the concrete peer
    types and isn't part of the generic peer interface. (The
    implementations of the command executor continue to call these
    methods.)
    
    The ultimate goal is to remove the per-command methods from the
    generic peer interface: the only interface-conforming way to
    call a command will be with the new executor API. At some point,
    we may want to move the methods outside of the peer classes and
    change the executor implementations to not call methods directly
    on a peer instance.
    
    Differential Revision: https://phab.mercurial-scm.org/D3273
    cc8c06835097