Skip to content
Snippets Groups Projects
Commit 07ac283f0ef5 authored by Georges Racinet's avatar Georges Racinet
Browse files

registry-pull: clarify image ID

Docker qualifies it with the hashing algorithm, as in `sha256:XXX` whereas
Podman does not. We found it hard to remember.
parent cb4e2f8828a4
No related branches found
No related tags found
No related merge requests found
Pipeline #72149 passed
......@@ -39,7 +39,8 @@
help="If specified, verify that the ID of the pulled "
"Docker image (as also displayed in heptapod-tests CI "
"jobs is the expected one. Note that the ID contains "
"the hash type specification (typically 'sha256:XXXX')")
"the hash type specification (typically 'XXXX', i.e., "
"without the `sha256` prefix)")
parser.add_argument('--omnibus-clone',
help="Path to a clone of %s to be used for "
"--verify-hg-tag. "
......@@ -89,6 +90,8 @@
expected_image_id = cl_args.expected_image_id
if expected_image_id is not None:
if not cl_args.podman:
expected_image_id = 'sha256:' + expected_image_id
if heptapod_registry_image_id == expected_image_id:
logger.info("Docker image ID is the expected %s", expected_image_id)
else:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment