various git pieces are confusing
I am on "Heptapod 0.12.0 80d6a51aa4d0 (GitLab CE 12.2.12)"
Apologies if these need to be broken down into three issues, but they are all small issues (though I understand the fix may not be small). Also, I am not sure if these need to be filed against the docker image or somewhere else, but since the docker image is the only supported version, I am filing here.
-
The GitLab branding is everywhere in the docker image, unlike heptapod.net. Perhaps this is intentional, but it is a bit confusing and I did not see an issue filed on this. I could also see this being a legal issue down the road (though I understand this is a friendly fork).
-
The ssh in the docker image references git: ssh://git@aa64903e3436/root/just-for-fun
In the heptapod.net version, these have been changed to hg, like ssh://hg@foss.heptapod.net/heptapod/heptapod-docker. This obviously makes more sense.
- Is git needed? docker exec aa64903e3436 /opt/gitlab/embedded/bin/git --version git version 2.22.2
Maybe it is there for migrations?
Anyway, there are a lot of files that reference git and if they are not needed it would be nice to get rid of them to reduce the size of the container:
docker exec aa64903e3436 find / -name git /opt/gitlab/embedded/bin/git /opt/gitlab/embedded/lib/ruby/2.6.0/bundler/source/git /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/bundler-1.17.3/lib/bundler/source/git /opt/gitlab/embedded/lib/ruby/site_ruby/2.6.0/bundler/source/git /opt/gitlab/embedded/libexec/git-core/git /opt/gitlab/embedded/service/gitaly-ruby/lib/gitlab/git /opt/gitlab/embedded/service/gitlab-rails/app/services/git /opt/gitlab/embedded/service/gitlab-rails/doc/topics/git /opt/gitlab/embedded/service/gitlab-rails/lib/flowdock/git /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/git /opt/gitlab/embedded/service/gitlab-rails/.hg/store/data/app/services/git /opt/gitlab/embedded/service/gitlab-rails/.hg/store/data/doc/topics/git /opt/gitlab/embedded/service/gitlab-rails/.hg/store/data/lib/flowdock/git /opt/gitlab/embedded/service/gitlab-rails/.hg/store/data/lib/gitlab/git /opt/gitlab/embedded/service/gitlab-rails/.hg/store/data/qa/qa/git /opt/gitlab/embedded/service/gitlab-rails/.hg/store/data/qa/spec/git /opt/gitlab/embedded/service/gitlab-rails/.hg/store/data/spec/lib/git /opt/gitlab/embedded/service/gitlab-rails/.hg/store/data/spec/lib/gitlab/git /opt/gitlab/embedded/service/gitlab-rails/.hg/store/data/spec/services/git /opt/gitlab/embedded/service/gitlab-rails/qa/qa/git /opt/gitlab/embedded/service/gitlab-rails/qa/spec/git /opt/gitlab/embedded/service/gitlab-rails/spec/lib/gitlab/git /opt/gitlab/embedded/service/gitlab-rails/spec/services/git /usr/local/lib/python2.7/dist-packages/hgext3rd/heptapod/tests/git