• Georges Racinet's avatar
    RSpec hg_access_protected_branches: removed lengthy setup · 611aad7f35ed
    Georges Racinet authored
    It turns out that these tests don't need the branches to actually
    exist. This gets the time to run this RSpec file down from 10
    minutes to less than 4 on my development workstation.
    
    That is enough to make sharding meaningful.
    
    Of course that raises the question whether they test anything,
    since some expected Forbidden could actually now be raised for
    the wrong reason. There is the case of the
    `safe_commit_for_new_protected_branch?` where one checks that
    protected branch rules are applied even if the commit actually
    creates the protected branch (through wildcard protection,
    that is indeed possible), but this is not currently covered,
    although it should.
    
    In other words actual coverage is no worse, and we should add
    new tests for the cases that aren't strongly covered,
    (perhaps UPSTREAM).
    
    The empty repo is a special case, but the general factory fixture
    takes care of that.
    
    --HG--
    branch : heptapod-stable
    611aad7f35ed
hg_access_protected_branches_spec.rb 11.3 KB