• Georges Racinet's avatar
    Passing vcs_type to GitlabShellWorker and fixing repo removal · 1f9e56d13b01
    Georges Racinet authored
    Because sidekiq workers don't seem to take named arguments, we
    pass it as the last required positional one and convert it to
    named argument in the actual call to `Gitlab::Shell`.
    
    Then it was simpler just to let `Gitlab::Shell#rm_namespace`, the
    only method not taking a `vcs_type` named arg to accept it for
    uniformity.
    
    All call sites for GitlabShellWorker are updated. There aren't so
    many, due to the general deprecation of `Gitlab::Shell`, also a
    reason not to worry about new callers appearing in future versions.
    
    Finally, the `remove` method wasn't even implemented in
    `HgGitRepository`.
    1f9e56d13b01