Inspect changes in Gitaly e8bd279636709887e70420ef64276022f25724f0
Upstream merge commit b7fc65900d0c changes Gitaly server version from 0e78015ff2052203845e049be8b3395bac782554 to e8bd279636709887e70420ef64276022f25724f0, with changes in protocol or one of the source subtrees currently under watch.
To further inspect, go to an up to date Gitaly source clone and run
diff 0e78015ff2052203845e049be8b3395bac782554..e8bd279636709887e70420ef64276022f25724f0 -- proto/*.proto internal/backup
. Here is a preview, truncated at 500 lines:
diff --git a/internal/backup/backup_test.go b/internal/backup/backup_test.go
index 46a8e840d..af905e9d0 100644
--- a/internal/backup/backup_test.go
+++ b/internal/backup/backup_test.go
@@ -70,7 +70,7 @@ func TestManager_Create(t *testing.T) {
cfg.SocketPath = testserver.RunGitalyServer(t, cfg, setup.RegisterAll)
ctx := testhelper.Context(t)
- repoCounter := counter.NewRepositoryCounter()
+ repoCounter := counter.NewRepositoryCounter(cfg.Storages)
for _, managerTC := range []struct {
desc string
@@ -238,7 +238,7 @@ func TestManager_Create_incremental(t *testing.T) {
cfg.SocketPath = testserver.RunGitalyServer(t, cfg, setup.RegisterAll)
ctx := testhelper.Context(t)
- repoCounter := counter.NewRepositoryCounter()
+ repoCounter := counter.NewRepositoryCounter(cfg.Storages)
for _, managerTC := range []struct {
desc string
@@ -382,7 +382,7 @@ func TestManager_Restore_latest(t *testing.T) {
cfg := testcfg.Build(t)
testcfg.BuildGitalyHooks(t, cfg)
cfg.SocketPath = testserver.RunGitalyServer(t, cfg, setup.RegisterAll)
- repoCounter := counter.NewRepositoryCounter()
+ repoCounter := counter.NewRepositoryCounter(cfg.Storages)
for _, managerTC := range []struct {
desc string
@@ -710,7 +710,7 @@ func TestManager_Restore_specific(t *testing.T) {
cfg := testcfg.Build(t)
testcfg.BuildGitalyHooks(t, cfg)
cfg.SocketPath = testserver.RunGitalyServer(t, cfg, setup.RegisterAll)
- repoCounter := counter.NewRepositoryCounter()
+ repoCounter := counter.NewRepositoryCounter(cfg.Storages)
for _, managerTC := range []struct {
desc string
A merge request may have already been submitted, check that on [merge commit commit](b7fc65900d0c, as usually changes in Gitaly are not breaking, compliance becoming mandatory in the following development cycles.