Inspect changes in Gitaly 26429785e300cc80f0f1d4856e25ab32df1cbf2c
Upstream merge commit 6753768d1845 changes Gitaly server version from 7a80007379240d0c628407b00062cf6f69c6334d to 26429785e300cc80f0f1d4856e25ab32df1cbf2c, with changes in protocol or one of the source subtrees currently under watch.
To further inspect, go to an up to date Gitaly source clone and run
diff 7a80007379240d0c628407b00062cf6f69c6334d..26429785e300cc80f0f1d4856e25ab32df1cbf2c -- proto/*.proto internal/backup
. Here is a preview, truncated at 500 lines:
diff --git a/internal/backup/pipeline.go b/internal/backup/pipeline.go
index 6ab2b29bf..e370e030b 100644
--- a/internal/backup/pipeline.go
+++ b/internal/backup/pipeline.go
@@ -171,19 +171,19 @@ func NewLoggingPipeline(log log.Logger) *LoggingPipeline {
// Handle takes a command to process. Commands are logged and executed immediately.
func (p *LoggingPipeline) Handle(ctx context.Context, cmd Command) {
log := p.cmdLogger(cmd)
- log.Infof("started %s", cmd.Name())
+ log.Info(fmt.Sprintf("started %s", cmd.Name()))
if err := cmd.Execute(ctx); err != nil {
if errors.Is(err, ErrSkipped) {
- log.WithError(err).Warnf("skipped %s", cmd.Name())
+ log.WithError(err).Warn(fmt.Sprintf("skipped %s", cmd.Name()))
} else {
- log.WithError(err).Errorf("%s failed", cmd.Name())
+ log.WithError(err).Error(fmt.Sprintf("%s failed", cmd.Name()))
p.addError(cmd.Repository(), err)
}
return
}
- log.Infof("completed %s", cmd.Name())
+ log.Info(fmt.Sprintf("completed %s", cmd.Name()))
}
func (p *LoggingPipeline) addError(repo *gitalypb.Repository, err error) {
A merge request may have already been submitted, check that on [merge commit commit](6753768d1845, as usually changes in Gitaly are not breaking, compliance becoming mandatory in the following development cycles.