Error 500 when creating a tag
Summary
Creating a new tag on a hg repository results in a 500 error page
Steps to reproduce
- Create a blank Mercurial project.
- Press the '+' drop down and select 'This Repository -> New tag'.
- Be directed to the 'New Tag' page (/-/tags/new).
- Complete the form (for example, with a tag name of 'tag1') and press 'Create tag'.
- Receive an error 500.
What is the current bug behavior?
Attempting to create a tag results in an error 500 page and no signs of the tag being created.
What is the expected correct behavior?
The tag should be created, or the UI to create tags hidden/
Relevant logs and/or screenshots
2024-02-12T18:31:38.478730Z INFO find_commit{correlation_id=Some("01HPF9DJ64V8QN13120M2NJK84") request=FindCommitRequest { repository: Some(Repository { storage_name: "default", relative_path: "@hashed/85/27/8527a891e224136950ff32ca212b45bc93f69fbb801c3b1ebedac52775f99e61.git", git_object_directory: "", git_alternate_object_directories: [], gl_repository: "project-14", gl_project_path: "XXX/tag-test" }), revision: "branch/default" }}: rhgitaly::service::commit: Processing
2024-02-12T18:31:38.479033Z INFO find_commit{correlation_id=Some("01HPF9DJ64V8QN13120M2NJK84") request=FindCommitRequest { repository: Some(Repository { storage_name: "default", relative_path: "@hashed/85/27/8527a891e224136950ff32ca212b45bc93f69fbb801c3b1ebedac52775f99e61.git", git_object_directory: "", git_alternate_object_directories: [], gl_repository: "project-14", gl_project_path: "XXX/tag-test" }), revision: "branch/default" }}: rhgitaly::service::commit: Revision resolved as da559fb589d9f7be587fa212bb228b1cfc37722a
{"component":"gitaly.UnaryServerInterceptor","correlation_id":"01HPF9DJ64V8QN13120M2NJK84","diskcache":"a4376cec-5d6b-488e-833d-28ab378e180e","grpc.meta.auth_version":"v2","grpc.meta.client_name":"gitlab-web","grpc.meta.deadline_type":"regular","grpc.meta.method_operation":"mutator","grpc.meta.method_scope":"repository","grpc.meta.method_type":"unary","grpc.method":"UserCreateTag","grpc.request.deadline":"2024-02-12T18:32:33.285","grpc.request.fullMethod":"/gitaly.OperationService/UserCreateTag","grpc.request.glProjectPath":"XXX/tag-test","grpc.request.glRepository":"project-14","grpc.request.repoPath":"@hashed/85/27/8527a891e224136950ff32ca212b45bc93f69fbb801c3b1ebedac52775f99e61.git","grpc.request.repoStorage":"default","grpc.service":"gitaly.OperationService","grpc.start_time":"2024-02-12T18:31:38.485","level":"info","msg":"diskcache state change","pid":319,"remote_ip":"XXX","span.kind":"server","system":"grpc","time":"2024-02-12T18:31:38.492Z","user_id":"3","username":"XXX"}
{"component":"gitaly.UnaryServerInterceptor","correlation_id":"01HPF9DJ64V8QN13120M2NJK84","error":"repository not found","error_metadata":{"relative_path":"@hashed/85/27/8527a891e224136950ff32ca212b45bc93f69fbb801c3b1ebedac52775f99e61.git","storage_name":"default"},"grpc.code":"NotFound","grpc.meta.auth_version":"v2","grpc.meta.client_name":"gitlab-web","grpc.meta.deadline_type":"regular","grpc.meta.method_operation":"mutator","grpc.meta.method_scope":"repository","grpc.meta.method_type":"unary","grpc.method":"UserCreateTag","grpc.request.deadline":"2024-02-12T18:32:33.285","grpc.request.fullMethod":"/gitaly.OperationService/UserCreateTag","grpc.request.glProjectPath":"XXX/tag-test","grpc.request.glRepository":"project-14","grpc.request.payload_bytes":222,"grpc.request.repoPath":"@hashed/85/27/8527a891e224136950ff32ca212b45bc93f69fbb801c3b1ebedac52775f99e61.git","grpc.request.repoStorage":"default","grpc.response.payload_bytes":0,"grpc.service":"gitaly.OperationService","grpc.start_time":"2024-02-12T18:31:38.485","grpc.time_ms":6.545,"level":"info","msg":"finished unary call with code NotFound","pid":319,"remote_ip":"XXX","span.kind":"server","system":"grpc","time":"2024-02-12T18:31:38.492Z","user_id":"3","username":"XXX"}
Gitlab::Git::Repository::NoRepository (5:repository not found.):
lib/gitlab/git/wraps_gitaly_errors.rb:16:in `rescue in wrapped_gitaly_errors'
lib/gitlab/git/wraps_gitaly_errors.rb:6:in `wrapped_gitaly_errors'
lib/gitlab/git/repository.rb:687:in `add_tag'
app/models/repository.rb:297:in `add_tag'
app/services/tags/create_service.rb:17:in `execute'
app/controllers/projects/tags_controller.rb:66:in `create'
app/controllers/application_controller.rb:514:in `set_current_admin'
lib/gitlab/session.rb:11:in `with_session'
app/controllers/application_controller.rb:505:in `set_session_storage'
lib/gitlab/i18n.rb:114:in `with_locale'
lib/gitlab/i18n.rb:120:in `with_user_locale'
app/controllers/application_controller.rb:496:in `set_locale'
app/controllers/application_controller.rb:489:in `set_current_context'
lib/gitlab/metrics/elasticsearch_rack_middleware.rb:16:in `call'
lib/gitlab/middleware/memory_report.rb:13:in `call'
lib/gitlab/middleware/speedscope.rb:13:in `call'
lib/gitlab/database/load_balancing/rack_middleware.rb:23:in `call'
lib/gitlab/middleware/rails_queue_duration.rb:33:in `call'
lib/gitlab/etag_caching/middleware.rb:21:in `call'
lib/gitlab/metrics/rack_middleware.rb:16:in `block in call'
lib/gitlab/metrics/web_transaction.rb:46:in `run'
lib/gitlab/metrics/rack_middleware.rb:16:in `call'
lib/gitlab/middleware/go.rb:20:in `call'
lib/gitlab/middleware/query_analyzer.rb:11:in `block in call'
lib/gitlab/database/query_analyzer.rb:37:in `within'
lib/gitlab/middleware/query_analyzer.rb:11:in `call'
lib/gitlab/middleware/multipart.rb:173:in `call'
lib/gitlab/middleware/read_only/controller.rb:50:in `call'
lib/gitlab/middleware/read_only.rb:18:in `call'
lib/gitlab/middleware/same_site_cookies.rb:27:in `call'
lib/gitlab/middleware/path_traversal_check.rb:48:in `call'
lib/gitlab/middleware/handle_malformed_strings.rb:21:in `call'
lib/gitlab/middleware/basic_health_check.rb:25:in `call'
lib/gitlab/middleware/handle_ip_spoof_attack_error.rb:25:in `call'
lib/gitlab/middleware/request_context.rb:15:in `call'
lib/gitlab/middleware/webhook_recursion_detection.rb:15:in `call'
config/initializers/fix_local_cache_middleware.rb:11:in `call'
lib/gitlab/middleware/compressed_json.rb:44:in `call'
lib/gitlab/middleware/rack_multipart_tempfile_factory.rb:19:in `call'
lib/gitlab/middleware/sidekiq_web_static.rb:20:in `call'
lib/gitlab/metrics/requests_rack_middleware.rb:79:in `call'
lib/gitlab/middleware/release_env.rb:13:in `call'
Details about the Heptapod instance where the bug occurs
Docker container installation:
Heptapod 1.0.1 (GitLab CE 16.6.7)
Mercurial 6.6.2 / Python 3.9.17 / hg-evolve 11.1.1