Inspect changes in Gitaly a22e2401ee6aa35ae70ca67013264b72fc29b6f5
Upstream merge commit cccc0463db37 changes Gitaly server version from 7a5df4f668644c2fefd7fda1ff6050eb8b68933b to a22e2401ee6aa35ae70ca67013264b72fc29b6f5, with changes in protocol or one of the source subtrees currently under watch.
To further inspect, go to an up to date Gitaly source clone and run:
git diff 7a5df4f668644c2fefd7fda1ff6050eb8b68933b..a22e2401ee6aa35ae70ca67013264b72fc29b6f5 -- proto/*.proto internal/backup
Here is a preview, truncated at 500 lines:
diff --git a/proto/commit.proto b/proto/commit.proto
index d1d24a33f..3815ab52e 100644
--- a/proto/commit.proto
+++ b/proto/commit.proto
@@ -391,7 +391,7 @@ message CountCommitsRequest {
GlobalOptions global_options = 9;
}
-// CountCommitsResponse is the response for the CountCommits RPC.
+// CountCommitsResponse is the response for the CountCommits RPC.
message CountCommitsResponse {
// count denotes the number of commits found as per the given filters.
int32 count = 1;
@@ -683,6 +683,20 @@ message FindCommitsResponse {
repeated GitCommit commits = 1;
}
+// FindCommitsError is an error returned by the FindCommits RPC when no commit is found.
+message FindCommitsError {
+
+ // error denotes the type of error encountered.
+ oneof error {
+ // bad_object is returned when the revision cannot be found in the git repository.
+ BadObjectError bad_object = 1;
+ // ambiguous_ref is returned when the given revision cannot be found.
+ AmbiguousReferenceError ambiguous_ref = 2;
+ // invalid_range is returned when the provided revision-range cannot be found in the git repository.
+ InvalidRevisionRange invalid_range = 3;
+ }
+}
+
// CommitLanguagesRequest requests to detect the source code languages.
message CommitLanguagesRequest {
// repository is the repository where to detect the languages in.
diff --git a/proto/errors.proto b/proto/errors.proto
index e2c0bd2e6..9ce8a52e5 100644
--- a/proto/errors.proto
+++ b/proto/errors.proto
@@ -205,3 +205,21 @@ message PathNotFoundError {
// path is the path that could not be found.
bytes path = 1;
}
+
+// AmbiguousReferenceError is an error returned when an reference is unknown.
+message AmbiguousReferenceError {
+ // reference is the reference passed to the git command.
+ bytes reference = 1;
+}
+// BadObjectError is an error returned when git cannot find a valid object based on its id.
+message BadObjectError {
+ // object_id is the object id passed to the git command.
+ bytes object_id = 1;
+}
+
+// InvalidRevisionRange is an error returned when the range given to the git log command is invalid.
+message InvalidRevisionRange {
+ // range is the commit range passed to git log command.
+ bytes range = 1;
+}
+
A merge request may have already been submitted, check that on the merge commit, as usually changes in Gitaly are not breaking, compliance becoming mandatory in the following development cycles.