Inspect changes in Gitaly 53e766d0e67117117fac0a3f83f6867ad82e461c
Upstream merge commit 7067b97ab893 changes Gitaly server version from 0f9df77f1f480d5f4087cc9400c13dcbab2e174e to 53e766d0e67117117fac0a3f83f6867ad82e461c, with changes in protocol or one of the source subtrees currently under watch.
The topic upstream-merge
is at 90 non-merge commits.
To further inspect, go to an up to date Gitaly source clone and run:
git diff 0f9df77f1f480d5f4087cc9400c13dcbab2e174e..53e766d0e67117117fac0a3f83f6867ad82e461c -- proto/*.proto internal/backup
Here is a preview, truncated at 500 lines:
diff --git a/proto/diff.proto b/proto/diff.proto
index fd0c7583c..0fc1f4e1c 100644
--- a/proto/diff.proto
+++ b/proto/diff.proto
@@ -360,7 +360,7 @@ message FindChangedPathsRequest {
}
}
- // repository ...
+ // repository is the repository the changed paths are computed in.
Repository repository = 1 [(target_repository)=true];
// commits is the list of commits to compare to their parents. This field is deprecated. To adapt to the new calling
// convention you can create one `CommitRequest` per commit, where each `CommitRequest` has only the `commit_revision`
@@ -371,6 +371,8 @@ message FindChangedPathsRequest {
// merge_commit_diff_mode controls how merge commits are treated.
MergeCommitDiffMode merge_commit_diff_mode = 4;
+ // find_renames toggles rename detection on the files in the diff.
+ bool find_renames = 5;
}
// FindChangedPathsResponse is the response for the FindChangedPaths RPC.
@@ -393,10 +395,12 @@ message ChangedPaths {
MODIFIED = 1; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX
// DELETED indicates a file was deleted.
DELETED = 2; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX
- // TYPE_CHANGE ...
+ // TYPE_CHANGE indicates change in the type of the file (regular file, symbolic link or submodule).
TYPE_CHANGE = 3; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX
- // COPIED ...
+ // COPIED indicates Git determined the file was copied.
COPIED = 4; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX
+ // RENAMED indicates Git determined the file was renamed.
+ RENAMED = 5; // protolint:disable:this ENUM_FIELD_NAMES_PREFIX
}
// path is the path of the change in question.
A merge request may have already been submitted, check that on the merge commit, as usually changes in Gitaly are not breaking, compliance becoming mandatory in the following development cycles.