Inspect changes in Gitaly d0e5fd708f7f3bdc05feb378ab1f09c485d3a3b5
Upstream merge commit 681d6705cad7 changes Gitaly server version from 53e766d0e67117117fac0a3f83f6867ad82e461c to d0e5fd708f7f3bdc05feb378ab1f09c485d3a3b5, with changes in protocol or one of the source subtrees currently under watch.
The topic upstream-merge
is at 13 non-merge commits.
To further inspect, go to an up to date Gitaly source clone and run:
git diff 53e766d0e67117117fac0a3f83f6867ad82e461c..d0e5fd708f7f3bdc05feb378ab1f09c485d3a3b5 -- proto/*.proto internal/backup
Here is a preview, truncated at 500 lines:
diff --git a/proto/log.proto b/proto/log.proto
index 82468fd04..0b1ecdb36 100644
--- a/proto/log.proto
+++ b/proto/log.proto
@@ -89,13 +89,13 @@ message LogEntry {
// permissions, will be shared with all of the hard links to the same file.
message CreateHardLink {
// source_path is the relative path of the file the hard link should point to.
- string source_path = 1;
+ bytes source_path = 1;
// source_in_storage is set when the source path is relative to the storage
// root instead of the log entry.
bool source_in_storage = 2;
// destination_path is a relative path from the storage root to where the hard
// link should be created at.
- string destination_path = 3;
+ bytes destination_path = 3;
}
// RemoveDirectoryEntry removes a directory or a file
@@ -103,13 +103,13 @@ message LogEntry {
// it must be empty.
message RemoveDirectoryEntry {
// path is the relative path of the directory entry to remove in the storage.
- string path = 1;
+ bytes path = 1;
}
// CreateDirectory creates a directory at a relative path.
message CreateDirectory {
// path is a relative path where to create the directory.
- string path = 1;
+ bytes path = 1;
// permissions are the Unix permision bits to set on the created directory.
uint32 permissions = 2;
}
A merge request may have already been submitted, check that on the merge commit, as usually changes in Gitaly are not breaking, compliance becoming mandatory in the following development cycles.