Error rendering Markdown containing ffffffff
This affects Issue titles, descriptions, comments, probably also Merge Requests… anything Markdown but not in HDK instances (probably more broadly not in development mode).
Unfortunately, because of the bug, we cannot spell it explicitely here until it is resolved: the hexadecimal representation (eight Fs) of ffffffff is mistaken for a changeset hash, but the HGitaly return value looks like a crash to the Rails app:2^32 - 1
(that's eight F nybbles)
Exception:
class: Gitlab::Git::CommandError
message: 2:Exception iterating responses: I/O operation on closed file.
backtrace:
lib/gitlab/git/wraps_gitaly_errors.rb:15:in `rescue in wrapped_gitaly_errors'
lib/gitlab/git/wraps_gitaly_errors.rb:6:in `wrapped_gitaly_errors'
lib/gitlab/git/commit.rb:206:in `batch_by_oid'
lib/gitlab/git/rugged_impl/commit.rb:53:in `batch_by_oid'
app/models/repository.rb:161:in `commits_by'
Also, while trying to report it, noticed that it happened also in litterals (inline or block), which is rather surprising and perhaps unrelated.
IIRC, this Node Id is the special representation of the working directory. In HGitaly context, that does not make any sense, and it should just return the proper value for changeset not found.