Inspect changes in Gitaly d3990ee4724c5aea9b6e1c0b3186607e60b72384
Upstream merge commit 67e1d18da977 changes Gitaly server version from a7a4ed3bafec15c90d064bd5b7a0c572fa38411d to d3990ee4724c5aea9b6e1c0b3186607e60b72384, with changes in protocol or one of the source subtrees currently under watch.
To further inspect, go to an up to date Gitaly source clone and run
diff a7a4ed3bafec15c90d064bd5b7a0c572fa38411d..d3990ee4724c5aea9b6e1c0b3186607e60b72384 -- proto/*.proto internal/backup
. Here is a preview, truncated at 500 lines:
diff --git a/proto/ref.proto b/proto/ref.proto
index c1aa14318..13dd5a0ab 100644
--- a/proto/ref.proto
+++ b/proto/ref.proto
@@ -129,14 +129,6 @@ service RefService {
};
}
- // PackRefs is deprecated in favor of OptimizeRepository.
- rpc PackRefs(PackRefsRequest) returns (PackRefsResponse) {
- option deprecated = true;
- option (op_type) = {
- op: MAINTENANCE
- };
- }
-
// ListRefs returns a stream of all references in the repository. By default, pseudo-revisions like HEAD
// will not be returned by this RPC. Any symbolic references will be resolved to the object ID it is
// pointing at.
@@ -545,20 +537,6 @@ message FindAllRemoteBranchesResponse {
repeated Branch branches = 1;
}
-// This comment is left unintentionally blank.
-message PackRefsRequest {
- // This comment is left unintentionally blank.
- Repository repository = 1 [(target_repository)=true];
-
- // DEPRECATED: https://gitlab.com/gitlab-org/gitaly/-/issues/3997
- reserved 2;
- reserved "all_refs";
-}
-
-// This comment is left unintentionally blank.
-message PackRefsResponse{
-}
-
// ListRefsRequest is a request for the ListRefs RPC.
message ListRefsRequest {
// This comment is left unintentionally blank.
diff --git a/proto/repository.proto b/proto/repository.proto
index a6aee4c0b..6723f119c 100644
--- a/proto/repository.proto
+++ b/proto/repository.proto
@@ -17,46 +17,6 @@ service RepositoryService {
};
}
- // RepackIncremental is deprecated in favor of OptimizeRepository.
- rpc RepackIncremental(RepackIncrementalRequest) returns (RepackIncrementalResponse) {
- option deprecated = true;
- option (op_type) = {
- op: MAINTENANCE
- };
- }
-
- // RepackFull is deprecated in favor of OptimizeRepository.
- rpc RepackFull(RepackFullRequest) returns (RepackFullResponse) {
- option deprecated = true;
- option (op_type) = {
- op: MAINTENANCE
- };
- }
-
- // MidxRepack is deprecated in favor of OptimizeRepository.
- rpc MidxRepack(MidxRepackRequest) returns (MidxRepackResponse) {
- option deprecated = true;
- option (op_type) = {
- op: MAINTENANCE
- };
- }
-
- // GarbageCollect is deprecated in favor of OptimizeRepository.
- rpc GarbageCollect(GarbageCollectRequest) returns (GarbageCollectResponse) {
- option deprecated = true;
- option (op_type) = {
- op: MAINTENANCE
- };
- }
-
- // WriteCommitGraph is deprecated in favor of OptimizeRepository.
- rpc WriteCommitGraph(WriteCommitGraphRequest) returns (WriteCommitGraphResponse) {
- option deprecated = true;
- option (op_type) = {
- op: MAINTENANCE
- };
- }
-
// RepositorySize returns information on the complete on-disk repository size. If you need more
// detailed information about the size of various sub-structures you should instead use the
// RepositoryInfo RPC.
@@ -221,14 +181,6 @@ service RepositoryService {
};
}
- // Cleanup is deprecated in favor of OptimizeRepository.
- rpc Cleanup(CleanupRequest) returns (CleanupResponse) {
- option deprecated = true;
- option (op_type) = {
- op: MAINTENANCE
- };
- }
-
// This comment is left unintentionally blank.
rpc GetSnapshot(GetSnapshotRequest) returns (stream GetSnapshotResponse) {
option (op_type) = {
@@ -399,86 +351,6 @@ message RepositoryExistsResponse {
bool exists = 1;
}
-// This comment is left unintentionally blank.
-message RepackIncrementalRequest {
- // This comment is left unintentionally blank.
- Repository repository = 1 [(target_repository)=true];
-}
-
-// This comment is left unintentionally blank.
-message RepackIncrementalResponse {
-}
-
-// This comment is left unintentionally blank.
-message RepackFullRequest {
- // This comment is left unintentionally blank.
- Repository repository = 1 [(target_repository)=true];
- // This comment is left unintentionally blank.
- bool create_bitmap = 2;
-}
-
-// This comment is left unintentionally blank.
-message RepackFullResponse {
-}
-
-// This comment is left unintentionally blank.
-message MidxRepackRequest {
- // This comment is left unintentionally blank.
- Repository repository = 1 [(target_repository)=true];
-}
-
-// This comment is left unintentionally blank.
-message MidxRepackResponse {
-}
-
-// This comment is left unintentionally blank.
-message GarbageCollectRequest {
- // This comment is left unintentionally blank.
- Repository repository = 1 [(target_repository)=true];
- // This comment is left unintentionally blank.
- bool create_bitmap = 2;
- // If set to 'true' the 'gc' will be triggered with '--prune=30.minutes.ago' flag.
- // This will remove dangling objects from the object storage that were not modified in the last 30 minutes.
- // If 'false' provided the 'gc' will rely on the default expiration period (2 weeks).
- // The window of 30 minutes exists because of possible concurrent operations running on the same
- // storage and removal of the objects may cause races and fail concurrent operations.
- bool prune = 3;
-}
-
-// This comment is left unintentionally blank.
-message GarbageCollectResponse {
-}
-
-// This comment is left unintentionally blank.
-message WriteCommitGraphRequest {
- // This comment is left unintentionally blank.
- enum SplitStrategy {
- // SizeMultiple requires to use '--split --size-multiple=4' strategy to create/update commit graph.
- // https://git-scm.com/docs/git-commit-graph#Documentation/git-commit-graph.txt-emwriteem
- // It is a default, there is no need to explicitly set it in the request.
- SizeMultiple = 0; // protolint:disable:this ENUM_FIELD_NAMES_UPPER_SNAKE_CASE ENUM_FIELD_NAMES_PREFIX ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH
- }
-
- // This comment is left unintentionally blank.
- Repository repository = 1 [(target_repository)=true];
- // SplitStrategy is a strategy used to create/update commit graph.
- SplitStrategy splitStrategy = 2; // protolint:disable:this FIELD_NAMES_LOWER_SNAKE_CASE
-}
-
-// This comment is left unintentionally blank.
-message WriteCommitGraphResponse {
-}
-
-// This comment is left unintentionally blank.
-message CleanupRequest {
- // This comment is left unintentionally blank.
- Repository repository = 1 [(target_repository)=true];
-}
-
-// This comment is left unintentionally blank.
-message CleanupResponse {
-}
-
// RepositorySizeRequest is a request for the RepositorySize RPC.
message RepositorySizeRequest {
// Repository is the repository for which to determine the repository size.
A merge request may have already been submitted, check that on [merge commit commit](67e1d18da977, as usually changes in Gitaly are not breaking, compliance becoming mandatory in the following development cycles.