Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • hgitaly hgitaly
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 45
    • Issues 45
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to a massive storm of spam, registration on this instance now requires explicit administrator approval. Sorry for the added friction, we're also looking into automatic filtering options.

  • heptapodheptapod
  • hgitalyhgitaly
  • Merge requests
  • !163

FindCommit comparison tests: ensure only GitLab state files are used

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Georges Racinet requested to merge topic/stable/find-commit-comp-test into branch/stable Jun 06, 2023
  • Overview 0
  • Commits 3
  • Pipelines 2
  • Changes 3

Previously, the test was passing because the Python reference implementation of HGitaly relies on scmutil.revsingle for revisions not found in GitLab state files, including tags given in simple form (e.g. v1.2.3).

But RHGitaly will rely on the GitLab state files only, hence we need to ensure that the tags state file contains the one we introduce, which is shadowing in the short SHA case

The added GitLab sync has the effect of removing directly set tags that have no Mercurial counterpart from the GitLab state file, that's why it has to occur before write_ref() in this test of collision/shadowing were Mercurial and Git tags must have different names.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: topic/stable/find-commit-comp-test