redis: Fix handling of passwords with a space
Previously we used `CGI.escape(password)`, but this escapes spaces as `+` instead of `%20`. However, RFC 3986 says the password should be percent-encoded. In fact, while the Ruby Redis client appears to connect fine with the `+`, the Go client doesn't work with that. Update the helper to encode passwords according to RFC 3986. Changelog: fixed
parent
0a1e6d56ce70
No related branches found
No related tags found
Showing
- files/gitlab-cookbooks/gitlab/libraries/redis_helper.rb 1 addition, 1 deletionfiles/gitlab-cookbooks/gitlab/libraries/redis_helper.rb
- files/gitlab-cookbooks/package/libraries/helpers/new_redis_helper.rb 1 addition, 1 deletion...b-cookbooks/package/libraries/helpers/new_redis_helper.rb
- spec/chef/cookbooks/gitlab/libraries/redis_uri_spec.rb 3 additions, 2 deletionsspec/chef/cookbooks/gitlab/libraries/redis_uri_spec.rb
- spec/chef/cookbooks/gitlab/recipes/gitlab-rails_spec.rb 5 additions, 5 deletionsspec/chef/cookbooks/gitlab/recipes/gitlab-rails_spec.rb
- spec/chef/cookbooks/gitlab/recipes/gitlab-workhorse_spec.rb 2 additions, 2 deletionsspec/chef/cookbooks/gitlab/recipes/gitlab-workhorse_spec.rb
- spec/chef/cookbooks/package/libraries/new_redis_helper/gitlab_workhorse_spec.rb 20 additions, 0 deletions...ckage/libraries/new_redis_helper/gitlab_workhorse_spec.rb
Loading
Please register or sign in to comment