Consolidate hyphenation and underscoring of keys to methods
Currently, we hyphenate first level keys when used as node attributes. However, because gitlab.rb uses an underscored form of these keys, it becomes confusing to figure out which form to use where. So, we are moving to underscored form everywhere. As a first step, we are consolidating the hyphenation and underscroring logic that is spread across the codebase into dedicated methods so that we can migrate services one at a time using an exception list. Related https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6873 Signed-off-by:Balasankar "Balu" C <balasankar@gitlab.com>
parent
30d7ba9b
No related branches found
No related tags found
Showing
- files/gitlab-cookbooks/gitlab/libraries/gitlab_rails.rb 2 additions, 1 deletionfiles/gitlab-cookbooks/gitlab/libraries/gitlab_rails.rb
- files/gitlab-cookbooks/gitlab/libraries/logging.rb 1 addition, 1 deletionfiles/gitlab-cookbooks/gitlab/libraries/logging.rb
- files/gitlab-cookbooks/gitlab/libraries/nginx.rb 4 additions, 2 deletionsfiles/gitlab-cookbooks/gitlab/libraries/nginx.rb
- files/gitlab-cookbooks/gitlab/recipes/default.rb 10 additions, 4 deletionsfiles/gitlab-cookbooks/gitlab/recipes/default.rb
- files/gitlab-cookbooks/logrotate/libraries/logrotate_helper.rb 6 additions, 5 deletions.../gitlab-cookbooks/logrotate/libraries/logrotate_helper.rb
- files/gitlab-cookbooks/monitoring/libraries/prometheus.rb 2 additions, 1 deletionfiles/gitlab-cookbooks/monitoring/libraries/prometheus.rb
- files/gitlab-cookbooks/package/libraries/config/roles/geo_secondary.rb 3 additions, 1 deletion...cookbooks/package/libraries/config/roles/geo_secondary.rb
- files/gitlab-cookbooks/package/libraries/deprecations.rb 4 additions, 3 deletionsfiles/gitlab-cookbooks/package/libraries/deprecations.rb
- files/gitlab-cookbooks/package/libraries/helpers/roles_helper.rb 3 additions, 1 deletion...itlab-cookbooks/package/libraries/helpers/roles_helper.rb
- files/gitlab-cookbooks/package/libraries/helpers/services_helper.rb 3 additions, 1 deletion...ab-cookbooks/package/libraries/helpers/services_helper.rb
- files/gitlab-cookbooks/package/libraries/settings_dsl.rb 24 additions, 4 deletionsfiles/gitlab-cookbooks/package/libraries/settings_dsl.rb
- spec/chef/cookbooks/package/libraries/settings_dsl_spec.rb 25 additions, 0 deletionsspec/chef/cookbooks/package/libraries/settings_dsl_spec.rb
Loading
Please register or sign in to comment