Skip to content
Snippets Groups Projects
Commit 3301b0118d82 authored by Robert Marshall's avatar Robert Marshall
Browse files

New config MRs should document allowed values

- When we review new configuration options, the merge request template
  should ensure we ask questions around what are the expected values to
  make sure it's covered in the review process.

Related https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/5935



Signed-off-by: default avatarRobert Marshall <rmarshall@gitlab.com>
parent d4da30672694
2 merge requests!67heptapod#675: making 0.31 the new stable,!66GitLab 14.9
......@@ -27,3 +27,4 @@
- [ ] Tests added
- [ ] Integration tests added to [GitLab QA](https://gitlab.com/gitlab-org/gitlab-qa)
- [ ] Equivalent MR/issue for the [GitLab Chart](https://gitlab.com/gitlab-org/charts/gitlab) opened
- [ ] Validate potential values for new configuration settings. Formats such as integer `10`, duration `10s`, URI `scheme://user:passwd@host:port` may require quotation or other special handling when rendered in a template and written to a configuration file.
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment