Skip to content
Snippets Groups Projects
Commit 40d4a733762f authored by Stan Hu's avatar Stan Hu
Browse files

Support password authentication for Redis Sentinel

This commit adds a separate password parameter for each Sentinel group
and enables GitLab Rails, Workhorse, and `gitlab-kas` to use a
password specified in `requirepass` in the Sentinel configuration:

```ruby
gitlab_rails['redis_sentinels_password']
gitlab_rails['redis_cache_sentinels_password']
gitlab_rails['redis_queues_sentinels_password']
gitlab_rails['redis_shared_state_sentinels_password']
gitlab_rails['redis_trace_chunks_sentinels_password']
gitlab_rails['redis_actioncable_sentinels_password']
gitlab_rails['redis_rate_limiting_sentinels_password']
gitlab_rails['redis_sessions_sentinels_password']
gitlab_rails['redis_cluster_rate_limiting_sentinels_password']
gitlab_rails['redis_repository_cache_sentinels_password']
```

We could avoid these extra configuration parameters by having the
admin specify a `password` parameter for each host/port combination in
`redis_sentinels`, `redis_cache_sentinels`, etc. However, this would
add much duplication in the configuration and different passwords
aren't actually supported by Redis Sentinel. gitlab-kas also expects a
single Sentinel password stored in the `sentinel_password_file`
configuration parameter.

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/235938

Changelog: added
parent ea165a3cdc9d
No related branches found
No related tags found
1 merge request!100Upstream Merge of 16.1 CE branching point
Showing
with 212 additions and 21 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment