Skip to content
Snippets Groups Projects
Commit 66e41b1cee20 authored by Balasankar 'Balu' C's avatar Balasankar 'Balu' C
Browse files

Deprecate usage of node['gitlab']['suggested-reviewers'] in gitlab.rb

Related https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6873



Changelog: deprecated

Signed-off-by: default avatarBalasankar "Balu" C <balasankar@gitlab.com>
parent 5c7944ea6804
No related branches found
No related tags found
2 merge requests!102heptapod#1237: making 0.38 the new oldstable,!92Merging upstream 15.10.0+ce.0
......@@ -161,3 +161,5 @@
default['gitlab']['geo-logcursor']['ha'] = false
default['gitlab']['geo-logcursor']['log_directory'] = '/var/log/gitlab/geo-logcursor'
default['gitlab']['geo-logcursor']['env_directory'] = '/opt/gitlab/etc/geo-logcursor/env'
default['gitlab']['suggested-reviewers'] = Gitlab::Deprecations::NodeAttribute.new(proc { node['gitlab']['suggested_reviewers'].to_h }, "node['gitlab']['suggested-reviewers']", "node['gitlab']['suggested_reviewers']")
......@@ -36,5 +36,5 @@
group 'root'
mode '0644'
sensitive true
variables(secret_token: node['gitlab']['suggested-reviewers']['api_secret_key'])
variables(secret_token: node['gitlab']['suggested_reviewers']['api_secret_key'])
dependent_services.each { |svc| notifies :restart, svc }
......@@ -40,3 +40,3 @@
dependent_services.each { |svc| notifies :restart, svc }
only_if { node['gitlab']['suggested-reviewers']['api_secret_key'] }
only_if { node['gitlab']['suggested_reviewers']['api_secret_key'] }
end
......@@ -259,6 +259,7 @@
postgres_exporter
pgbouncer_exporter
gitlab_shell
suggested_reviewers
]
return underscored_form(key) if skip_hyphenation.include?(underscored_form(key))
......
......@@ -33,6 +33,7 @@
%w[postgres-exporter postgres_exporter],
%w[pgbouncer-exporter pgbouncer_exporter],
%w[gitlab-shell gitlab_shell],
%w[suggested-reviewers suggested_reviewers],
].each do |input, output|
expect(subject.sanitized_key(input)).to eq(output)
end
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment