Sync trailing slash usage for GitLab KAS routes
The GitLab Nginx templates uses the non-changeable routes `-/kubernetes-agent/` and `-/kubernetes-agent/k8s-proxy/` for KAS/KAS K8s API proxy forwarding. Both routes use trailing slashes while the GitLab rails configuration by default generates routes without trailing slashes. This will cause GitLab to generate a KAS configuration with invalid target URL, causing a connection failure as the server returns a HTTP 301 instead of 101. This commit syncs the temples to consistently using a trailing slash. Besides that, two other minor points were addressed: - The `gitlab_kas_external_k8s_proxy_url` example in `gitlab.rb.template` wrongly used the `wss://` schema but is in fact a reverse proxy for a K8s API. This was corrected to use `https://` instead. - The inline comment in `gitlab_kas.rb` used a wrong path reference. This was corrected as well Changelog: fixed
parent
63a6c1ceb91c
No related branches found
No related tags found
Showing
- files/gitlab-config-template/gitlab.rb.template 2 additions, 2 deletionsfiles/gitlab-config-template/gitlab.rb.template
- files/gitlab-cookbooks/gitlab-kas/libraries/gitlab_kas.rb 4 additions, 4 deletionsfiles/gitlab-cookbooks/gitlab-kas/libraries/gitlab_kas.rb
- spec/chef/recipes/gitlab-kas_spec.rb 5 additions, 5 deletionsspec/chef/recipes/gitlab-kas_spec.rb
Please register or sign in to comment