Use bundler to install Omnibus gems
Instead of calling `gem install <x>` many times, let's define the `Gemfile` and `Gemfile.lock` and run `bundle install`. This ensures dependencies are pinned and don't quietly move with a new invocation of `gem install`. There is also a side benefit to using `bundler`: we can later use the newly-introduced feature to include and verify checksums (https://github.com/rubygems/rubygems/pull/6374). `bundler` generally installs everything in the expected gem directory that is used by `ruby`, but for gems installed from a Git source, `bundler` puts those gems in a special `bundler/gems` directory. We don't use any gems from Git sources now--`gitlab-ruby-shadow` is now used instead of `ruby-shadow`--there is no issue. Also, note that if we want to ensure `gitlab-ctl` doesn't try to pull in gems from GitLab Rails, we could invoke `bundler`, but this is a slightly riskier change. Relates to https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8368 Changelog: changed
parent
3aa1f00526cf
No related branches found
No related tags found
Showing
- config/patches/acme-client/add-license-file.patch 0 additions, 27 deletionsconfig/patches/acme-client/add-license-file.patch
- config/patches/chef-bin/add-license-file.patch 0 additions, 207 deletionsconfig/patches/chef-bin/add-license-file.patch
- config/patches/chef-zero/license/add-license-file.patch 0 additions, 207 deletionsconfig/patches/chef-zero/license/add-license-file.patch
- config/patches/mixlib-log/license/add-license-file.patch 0 additions, 207 deletionsconfig/patches/mixlib-log/license/add-license-file.patch
- config/patches/mixlib-log/license/add-notice-file.patch 0 additions, 34 deletionsconfig/patches/mixlib-log/license/add-notice-file.patch
- config/patches/ohai/license/add-license-file.patch 0 additions, 207 deletionsconfig/patches/ohai/license/add-license-file.patch
- config/patches/ohai/license/add-notice-file.patch 0 additions, 38 deletionsconfig/patches/ohai/license/add-notice-file.patch
- config/patches/tomlib/license/add-license-file.patch 0 additions, 27 deletionsconfig/patches/tomlib/license/add-license-file.patch
- config/projects/gitlab.rb 1 addition, 6 deletionsconfig/projects/gitlab.rb
- config/software/acme-client.rb 0 additions, 33 deletionsconfig/software/acme-client.rb
- config/software/chef-acme.rb 1 addition, 1 deletionconfig/software/chef-acme.rb
- config/software/chef-bin.rb 0 additions, 63 deletionsconfig/software/chef-bin.rb
- config/software/chef-gem.rb 1 addition, 9 deletionsconfig/software/chef-gem.rb
- config/software/chef-zero.rb 0 additions, 47 deletionsconfig/software/chef-zero.rb
- config/software/faraday-cage.rb 0 additions, 54 deletionsconfig/software/faraday-cage.rb
- config/software/gitaly.rb 1 addition, 1 deletionconfig/software/gitaly.rb
- config/software/mixlib-log.rb 0 additions, 40 deletionsconfig/software/mixlib-log.rb
- config/software/ohai.rb 0 additions, 40 deletionsconfig/software/ohai.rb
- config/software/omnibus-gitlab-gems.rb 55 additions, 0 deletionsconfig/software/omnibus-gitlab-gems.rb
- config/software/remote-syslog.rb 0 additions, 34 deletionsconfig/software/remote-syslog.rb
Loading
Please register or sign in to comment