Skip to content
Snippets Groups Projects
  1. Nov 15, 2024
    • Andrew Patterson's avatar
      Disallow login for mattermost account · d4bce1d32866
      Andrew Patterson authored
      Change login shell for mattermost account to
      nologin to stop CIS from triggering rule 6.2.8
      "Ensure users' home directories permissions are
      750 or more restrictive".
      d4bce1d32866
  2. Oct 18, 2024
  3. Nov 05, 2024
    • Stan Hu's avatar
      Make ActionCable Redis settings use default Redis Sentinel password · 6c142799e37c
      Stan Hu authored
      Suppose you have this config:
      
      ```
      gitlab_rails['redis_sentinels'] = [
        {"host"=>"gitlabtest-cluster-redis-01", "port"=>26379},
        {"host"=>"gitlabtest-cluster-redis-02", "port"=>26379},
        {"host"=>"gitlabtest-cluster-redis-03", "port"=>26379}
      ]
      gitlab_rails['redis_sentinels_password'] = "some password"
      redis['enable'] = false
      redis['master_name'] = "gitlab-redis"
      redis['master_password'] = "some password"
      ```
      
      Previously ActionCable Redis settings would only look for
      `gitlab_rails['redis_actioncable_sentinels_password']` and did
      not fall back to `gitlab_rails['redis_sentinels_password']`.
      
      Relates to https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8728
      
      Changelog: fixed
      6c142799e37c
  4. Oct 22, 2024
  5. Sep 20, 2024
  6. Sep 19, 2024
  7. Sep 11, 2024
  8. Sep 18, 2024
  9. Sep 17, 2024
  10. Sep 04, 2024
  11. Aug 26, 2024
  12. Aug 23, 2024
  13. Aug 21, 2024
  14. Aug 19, 2024
  15. Aug 14, 2024
  16. Aug 13, 2024
  17. Aug 01, 2024
  18. Aug 06, 2024
  19. Jul 15, 2024
  20. Jul 11, 2024
  21. Jul 15, 2024
  22. Jul 12, 2024
  23. Jun 30, 2024
  24. Apr 15, 2024
  25. Jul 12, 2024
  26. Jul 10, 2024
  27. Apr 08, 2024
  28. Jun 26, 2024
    • Stan Hu's avatar
      Attempt to retry twice to determine Redis server version · 91afd5f5b826
      Stan Hu authored
      We had two different customers upgrade GitLab and run into `stderr:
      Error: Connection reset by peer` when attempting to determine the
      Redis version. This appears to have occurred because `gitlab-ctl
      reconfigure` can restart Redis right before it checks the version.
      This causes the `gitlab-ctl reconfigure` to fail outright.
      
      To avoid this failure mode, set the Chef `retries` parameter to 2. By
      default the `retry_delay` is 2 seconds.
      
      Relates to
      https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8597
      
      Changelog: fixed
      91afd5f5b826
  29. Jun 27, 2024
    • Stan Hu's avatar
      Fix Redis password handling with reserved characters · ba009e3bf187
      Stan Hu authored
      Previously including reserved characters such as `@` in the Redis
      password would fail because `URI::Generic::DEFAULT_PARSER.escape` did
      not consider `@` unsafe, which it generally isn't per RFC 2396 and
      3986. However, the `@` is not allowed in the userinfo field, and the
      URI builder for Ruby fails if using a reserved character were
      included.
      
      To fix this, use `ERB.url_encode`, which always escapes any
      non-alphanumeric string.
      
      Relates to https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8602
      
      Changelog: fixed
      ba009e3bf187
  30. Jun 04, 2024
  31. Jun 24, 2024
  32. Jun 12, 2024
    • Vasilii Iakliushin's avatar
      Disable request buffering for new SSH endpoints · ed3f9dbbf52b
      Vasilii Iakliushin authored
      Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/466160
      
      **Problem**
      
      While testing the new implementation of SSH endpoints for git related
      actions. I noticed a problem reproducible in my
      local environment.
      
      The request from GitLab-Shell to Workhorse was hanging. After in
      investigation I discovered the root cause of this problem.
      
      In our NGINX configuration we use request buffering. After adding the
      new endpoint to the list of exceptions, then problem was resolved.
      
      **Solution**
      
      Add new endpoints to the list of exceptions for nginx configuration.
      
      Changelog: changed
      ed3f9dbbf52b
  33. Jun 24, 2024
    • Ian Baum's avatar
      Add gitlab-backup user · ab269a7991a2
      Ian Baum authored
      * Creates the gitlab-backup user and groups if they dont' exist
      * Adds the user to other groups
      * For use by gitlab-backup-cli for read/write permission to data for
        backups and restores
      
      Changelog: added
      ab269a7991a2
  34. Jun 19, 2024
  35. Jun 13, 2024
Loading