Skip to content
Snippets Groups Projects
Commit 7b46103e authored by Georges Racinet's avatar Georges Racinet
Browse files

GitLab Hooks: making sure repo object is used only for path and ui

Because the post-receive hook is now called in the locks release
callback, we need to make sure it doesn't use anything that the
release just invalidated, notably weak refs.

But the hooks were only using the repository object for

- the path to the repository (taking sharing into account)
- `repo.ui`

We now extract these two elements, and immediately delete the
reference to the repository object. Both linters and the tests
with full coverage complete the proof that no other use is
occurring.
parent c81b287a
No related branches found
No related tags found
1 merge request!63Post Receive after lock
Pipeline #23686 passed
Pipeline: hgitaly

#23689

    Loading
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Finish editing this message first!
    Please register or to comment