Skip to content

Restore after format: refactoring + fix for EOS-M

Alex requested to merge branch/restore-after-format into branch/unified

Issue https://bitbucket.org/hudson/magic-lantern/issue/2078/eos-m-cant-tap-to-switch-keep-ml-when

This used to work back then (1-2 years ago?), but lately it was broken for a loooooooong time and nobody noticed it. So, this looks like a good opportunity to check it on all other cameras.

=> please check the following:

  • whether you can toggle between "Format card, keep ML" and "Format card, remove ML"
  • whether you can still change stuff in Canon's format dialog (EOS-M uses the touchscreen for this, and it looks like there may be a better choice here)
  • whether the messages about "restoring file XX" are printed in the correct place (in Canon menu, in the same place as the Format menu entry)

TODO:

  • another known bug (and again, unreported) is that config presets will not be restored (because they are in subdirectories). To fix, we need to scan the ML directory recursively and not just some preset folders.
  • move this feature to a separate file?

Merge request reports