Skip to content

Increase MAX_PRECREATE_FILES to 32 for 128GB cards: http://www.magiclantern.fm/forum/index.php?topic=12686.0

Bitbucket Importer requested to merge bitbucket/declined-pr-607 into branch/unified

Created originally on Bitbucket by Audionut

Changesets for this Pull Request have not been imported, because it had been already declined on Bitbucket. Marked as closed by the import user.

TODO:

  • Wait for user feedback
  • Better define the number based on card size / Improve backend file handling

Since the size of these files is miniscule, this solution is suitable IMHO. However, during an error condition these files remain on the card. When we're creating 32 files at each record start, there's a chance of thousands of these files being created and remaining on the card under the right circumstances.

A solution would be to define the number based on the card size. Then those with smaller cards wouldn't create so many files under an error condition. Not the cleanest solution, but probably something that I could do with help.

Better solution, improve the file handling backend to remove any files created erroneously. This solution is way above my paygrade.

Merge request reports