Skip to content
Snippets Groups Projects

topic: allow unicode symbols in names as long as they are alphanumeric

Merged Anton Shestakov requested to merge topic/default/unicode-topics into branch/default
  1. Mar 19, 2022
    • Anton Shestakov's avatar
      topic: allow unicode symbols in names as long as they are alphanumeric · 2ec9c87e8574
      Anton Shestakov authored
      I decided to relax this logic just a little bit to allow unicode "word
      characters" (i.e. everything that a unicode regex \w matches). This is still
      limiting cases that core allows (for branches and bookmarks): core only forbids
      certain byte values (like null byte, see scmutil.checknewlabel function).
      
      This extra check for topic names could be dropped altogether and we could rely
      solely on checknewlabel(), but I don't know if there isn't some corner case
      that topics can't handle. Needs more investigation (and tests).
      2ec9c87e8574
Loading