Skip to content
Snippets Groups Projects
  • Dan Villiom Podlaski Christiansen's avatar
    a28216b2
    incoming: stop caching dulwich objects · a28216b2
    Dan Villiom Podlaski Christiansen authored
    This is a premature optimisation, since Dulwich does a lot caching
    internally anyway. I have been unable to demonstrate any benefit from
    this; a bit of profiling shows that this stage of an incoming
    command takes ~12 seconds, even with more than 100k commits.
    
    Generally speaking, the actual conversion will take significantly
    longer time than caching these objects. In fact, the cache might
    actually be harmful for very long-running conversions, as they tend to
    run into memory constraints.
    a28216b2
    History
    incoming: stop caching dulwich objects
    Dan Villiom Podlaski Christiansen authored
    This is a premature optimisation, since Dulwich does a lot caching
    internally anyway. I have been unable to demonstrate any benefit from
    this; a bit of profiling shows that this stage of an incoming
    command takes ~12 seconds, even with more than 100k commits.
    
    Generally speaking, the actual conversion will take significantly
    longer time than caching these objects. In fact, the cache might
    actually be harmful for very long-running conversions, as they tend to
    run into memory constraints.