Skip to content
Snippets Groups Projects
Commit b7843bf6 authored by Dan Villiom Podlaski Christiansen's avatar Dan Villiom Podlaski Christiansen
Browse files

pull: ensure that all commits are at least draft

Previously, setting phases.new-commit to `secret` would trigger an
error in clone:

  abort: filtered revision '7fe02317c63d9ee324d4b5df7c9296085162da1b'

I'm not entirely sure why that happens, I didn't delve too deeply.
Essentially, pulls from hg-git _should_ be draft, so I fixed that
instead. The `secret` phase is for stuff neither to push to Mercurial
nor Git; it does not distinguish commits based on their origin.

The bug report dates from several years ago; so long ago that one
might reasonably debate whether this is a bug fix or an enhancement.
Since fixing old code is significantly easier on default, that's where
I've put this change.

This is only a partial fix, that focuses on the bug specifically; it
doesn't address edge-cases where a pull might only affect phases. For
clarity and documentation, I've left the incorrect behaviour in the
tests.

Fixes #266
parent 12b35d9a
No related branches found
No related tags found
1 merge request!103pull: ensure that all commits are at least draft
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment