pull: ensure that all commits are at least draft
Previously, setting phases.new-commit to `secret` would trigger an error in clone: abort: filtered revision '7fe02317c63d9ee324d4b5df7c9296085162da1b' I'm not entirely sure why that happens, I didn't delve too deeply. Essentially, pulls from hg-git _should_ be draft, so I fixed that instead. The `secret` phase is for stuff neither to push to Mercurial nor Git; it does not distinguish commits based on their origin. The bug report dates from several years ago; so long ago that one might reasonably debate whether this is a bug fix or an enhancement. Since fixing old code is significantly easier on default, that's where I've put this change. This is only a partial fix, that focuses on the bug specifically; it doesn't address edge-cases where a pull might only affect phases. For clarity and documentation, I've left the incorrect behaviour in the tests. Fixes #266
parent
12b35d9a
No related branches found
No related tags found
Showing
- hggit/git_handler.py 4 additions, 2 deletionshggit/git_handler.py
- hggit/util.py 17 additions, 0 deletionshggit/util.py
- tests/test-clone.t 10 additions, 0 deletionstests/test-clone.t
- tests/test-git-tags.t 32 additions, 0 deletionstests/test-git-tags.t
- tests/test-pull.t 10 additions, 0 deletionstests/test-pull.t
Loading
Please register or sign in to comment