Skip to content
Snippets Groups Projects
  1. Feb 06, 2018
  2. Oct 16, 2015
  3. Aug 23, 2014
  4. May 20, 2014
  5. Jan 06, 2013
    • David M. Carr's avatar
      push: add more output about what was added (issue #64) · 163c4525
      David M. Carr authored
      l33t pointed out that currently, Hg-Git doesn't provide any confirmation that a
      push was successful other than the exit code.  Normal Mercurial provides a
      couple other messages followed by "added X changesets with Y changes to
      Z files".  After this change, Hg-Git will provide much more similar output.
      It's not identical, as the underlying model is substantially different, but the
      concept is the same.  The main message is "added X commits with Y trees and
      Z blobs".
      
      This change doesn't affect the output of what references/branches were touched.
      That will be addressed in a subsequent commit.
      
      Dulwich doesn't provide an easy hook to get the information needed for this
      output.  Instead of passing generate_pack_contents as the pack generator
      function to send_pack, I pass a custom function that determines the "missing"
      objects, stores the counts, and then calls generate_pack_contents (which then
      will determine the "missing" objects again.
      
      The new expected output:
      searching for changes # unless quiet true
      <N> commits found     # if verbose true
      list of commits:      # if debugflag true and at least one commit found
      <each hash>           # if debugflag true and at least one commit found
      adding objects        # if at least one commit found unless quiet true
      added <N> commits with <N> trees and <N> blobs # if at least one object unless
                                                     # quiet true
      
      https://bitbucket.org/durin42/hg-git/issue/64/push-confirmation
      163c4525
  6. Nov 03, 2012
    • David M. Carr's avatar
      tests: convert echos to comments · 52461f71
      David M. Carr authored
      Now that we're in the unified test format, there isn't a need to use echo
      to provide context to command output.  This technique actually ends up resulting
      in redundant output.  To preserve the original context, but eliminate the
      redundancy, such echo statements have been converted into comment lines.
      52461f71
    • David M. Carr's avatar
      tests: avoid changing the current directory · 6cc99298
      David M. Carr authored
      Mercurial allows specifying which repository to use via the -R/--repository
      option.  Git allows a similar function using the --git-dir option.  By using
      these options, in many cases we can avoid checking the current directory.
      This makes tests easier to understand, as you don't need to remember which
      directory you're in to understand what's going on.  It also makes tests easier
      to write, as you don't need to remember to cd out of a directory when you're
      done doing things there.
      
      Thanks to Felipe Contreras for the patch which this was based on.
      6cc99298
    • David M. Carr's avatar
      tests: extract git command-line client and dulwich requirements into testutil · 675f19af
      David M. Carr authored
      One or both of these requirements were in almost every test in exactly the same
      way.  Now, these checks are performed in every test that uses the testutil.
      This makes it easier for test authors to add these checks into new tests (just
      add a reference to the testutil, which you'd probably want anyway).
      
      We considered having each test declare their requirements (currently, either
      "git" or "dulwich"), but in this case, preferred the simplicity of having the
      check always performed (even if a particular test doesn't need one or the
      other).  You can't perform any meaningful testing of Hg-Git without both of
      these dependencies properly configured.  The main value to checking for them
      in the tests (rather than just letting the tests fail) is that it gives a
      meaningful error message to help people figure out how to fix their environment.
      In the case that either git or dulwich is missing, the information will be
      just as clearly conveyed regardless of whether its all the tests that are
      skipped, or just most of them.
      
      I didn't add dulwich to hghave (even though this is clearly the sort of thing
      that hghave is intended for) because hghave is currently pulled from Mercurial
      completely unchanged, and it's probably best to keep it that way.
      
      Tested by running the tests in three configurations:
       * No dulwich installed (ran 0, skipped 28, failed 0, output:
              Skipped *: missing feature: dulwich)
       * Bad git on path (ran 1, skipped 27, failed 0, output:
              Skipped *: missing feature: git command line client)
       * Working git and correct version of dulwich installed
              (ran 28, skipped 0, failed 0)
      
      Thanks to Felipe Contreras for the idea to extract this logic into a library.
      675f19af
  7. Oct 31, 2012
    • David M. Carr's avatar
      tests: let git init create directories when applicable · 935c4fb1
      David M. Carr authored
      It's functionally equivalent to create a directory, cd into it, git init, and
      cd out of the directory, or simply git init with the directory specified.
      
      In several cases, we were doing the former without performing any other
      operations in the git repo, which just made the test unneccesarily complex.
      Even in the case where we still want to cd into the directory, calling git
      init with the directory name eliminates the need for a separate mkdir command.
      
      This changeset converts the former approach to the latter with the goal of
      increasing the readability of the tests.
      
      Thanks to Felipe Contreras for the patch which this was based on.
      935c4fb1
    • David M. Carr's avatar
      tests: extract extension configuration into a testutil library · a7da97e6
      David M. Carr authored
      Thanks to Felipe Contreras for the patch which this was based on.
      
      Even though the MQ extension was only used in a single test
      (test-pull-after-strip.t), I included it in the testutil.  It shouldn't hurt
      anything to have it enabled and not used, and saves us from having to deal
      with enabling extensions in individual tests at all.
      
      Similarly, this changeset results in the graphlog extension being enabled
      for all tests, even though there were some that didn't use it before.  This is
      even less significant in Mercurial 2.3+, since in those versions, graphlog is
      part of core, and is available even when the extension is disabled.
      a7da97e6
  8. Oct 29, 2012
  9. Oct 26, 2012
  10. Oct 08, 2012
  11. Sep 14, 2012
    • David M. Carr's avatar
      tests: eliminate use of git-daemon · 7edcbdd2
      David M. Carr authored
      Dulwich now supports local repositories just fine.  Not using the daemon makes
      the tests easier to read and more reliable (less likely to be skipped because
      a stray daemon is holding onto the port).
      7edcbdd2
    • David M. Carr's avatar
      tests: remove piping of command git init to remove leading path · e48a3f30
      David M. Carr authored
      In many cases we were piping to a python script to strip out the varying leading
      path to the test repos.  This is no longer needed, as the modern run-test.py
      automatically substitutes the leading path as $TESTTMP.  Eliminating the piping
      makes the tests easier to read and write, as well as allowing the exit codes
      to be verified by the test.
      e48a3f30
    • David M. Carr's avatar
      tests: remove configuration of bookmarks extension · bc7b18c2
      David M. Carr authored
      All of our supported Hg versions include bookmarks in core.  Thus, actovating
      it in the hgrc and setting bookmarks.track.current are no longer needed.
      bc7b18c2
  12. Sep 10, 2012
  13. Jan 27, 2012
  14. May 25, 2011
  15. May 22, 2011
Loading