Skip to content
Snippets Groups Projects
  1. Feb 19, 2014
  2. Feb 20, 2014
    • Siddharth Agarwal's avatar
      tests: upgrade run-tests.py · 0b33ab75
      Siddharth Agarwal authored
      This is the version in Mercurial rev 87e52e642562, plus a patch to make
      --with-hg work for system hg (sent upstream). Importantly, this gets us the
      hash seed randomization we need for bugs like the one fixed by the parent
      commit to be detected.
      0b33ab75
    • Siddharth Agarwal's avatar
      hg2git: fix subrepo handling to be deterministic · fbfa6353
      Siddharth Agarwal authored
      Previously, the correctness of _handle_subrepos was based on the order the
      files were processed in. For example, consider the case where a subrepo at
      location 'loc' is replaced with a file at 'loc', while another subrepo exists.
      This would cause .hgsubstate and .hgsub to be modified and the file added.
      
      If .hgsubstate was seen _before_ 'loc' in the modified/added loop, then
      _handle_subrepos would run and remove 'loc' correctly, before 'loc' was added
      back later. If, however, .hgsubstate was seen _after_ 'loc', then
      _handle_subrepos would run after 'loc' was added and would remove 'loc'.
      
      With this patch, _handle_subrepos merely computes the changes that need to be
      applied. The changes are then applied, making sure removed files and subrepos
      are processed before added ones.
      
      This was detected by setting a random PYTHONHASHSEED (in this case, 3910358828)
      and running the test suite against it. An upcoming patch will randomize the
      PYTHONHASHSEED in run-tests.py, just like is done in Mercurial.
      fbfa6353
    • Siddharth Agarwal's avatar
      hg2git: move parse_subrepos to top level · 71fb5dd6
      Siddharth Agarwal authored
      durin42 expressed a desire for this function to be at the top level.
      71fb5dd6
  3. Feb 19, 2014
  4. Feb 16, 2014
  5. Feb 13, 2014
  6. Feb 16, 2014
  7. Feb 13, 2014
  8. Feb 14, 2014
    • Siddharth Agarwal's avatar
      git_handler: fix hgsubstate generation · f492e475
      Siddharth Agarwal authored
      Before this patch, in the git to hg conversion, .hgsubstate once created is
      never deleted, even if no submodules are any longer present. This is broken
      state, as shown by the test for which the SHA changes. Fix that by looking at
      the diff instead of just what submodules are present.
      
      Since 'gitlinks' now contains *changed* gitlinks, not *all* gitlinks, it no
      longer makes sense to gate gitmodules checks on that.
      
      This patch simply demonstrates that the test was broken; an upcoming patch will
      introduce more tests.
      
      Bonus: this also makes the import process faster because we no longer need to
      walk the entire tree to collect gitlinks.
      
      This will cause the SHAs of repos that have submodules added and then removed
      to change.
      f492e475
  9. Feb 15, 2014
  10. Feb 14, 2014
Loading