Skip to content
Snippets Groups Projects
Commit ac5057d5 authored by Martin von Zweigbergk's avatar Martin von Zweigbergk
Browse files

verify: recover lost freeing of memory

In df8973e1fb45 (verify: move file cross checking to its own function,
2016-01-05), "mflinkrevs = None" was moved into function, so the
reference was cleared there, but the calling function now held on to
the variable. The point of clearing it was presumably to free up
memory, so let's move the clearing to the calling function where it
makes a difference. Also change "mflinkrevs = None" to "del
mflinkrevs", since the comment about scope now surely is obsolete.
parent 07a5de79
No related branches found
No related tags found
No related merge requests found
......@@ -149,6 +149,7 @@
filenodes = self._verifymanifest(mflinkrevs)
self._crosscheckfiles(mflinkrevs, filelinkrevs, filenodes)
del mflinkrevs
totalfiles, filerevisions = self._verifyfiles(filenodes, filelinkrevs)
......@@ -249,7 +250,6 @@
ui.progress(_('crosschecking'), count, total=total)
self.err(c, _("changeset refers to unknown manifest %s") %
short(m))
mflinkrevs = None # del is bad here due to scope issues
for f in sorted(filelinkrevs):
count += 1
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment