Skip to content
Snippets Groups Projects
  1. May 01, 2018
  2. May 03, 2018
  3. May 01, 2018
  4. Apr 28, 2018
  5. Jun 06, 2018
  6. Jun 02, 2018
  7. Jun 01, 2018
    • Matt Harbison's avatar
      tests: adapt test-check-pylint to run on Windows · 6ae62d62
      Matt Harbison authored
      The line endings are explicitly converted because this was ending up with
      '\r (no-eol) (esc)' lines, in addition to the usual '\r (esc)' lines.  I've seen
      the fakerc output on other recently installed systems though (10.13 and/or
      Fedora 26).  Unfortunately, the output here uses '\\' on Windows, so glob away
      the whole path.
      6ae62d62
    • Matt Harbison's avatar
      hghave: avoid a deadlock reading the child process's output · 6fb76897
      Matt Harbison authored
      The output of `pylint` is voluminous enough that it fills the buffer on Windows,
      and waited for the parent to read it out.  But the parent was waiting on the
      child to exit.
      
      I'm not sure what the intent of setting `ret = -1` in the exception handler just
      above this was...
      6fb76897
  8. May 31, 2018
    • Matt Harbison's avatar
      lfs: bypass wrapped functions when reposetup() hasn't been called (issue5902) · 3790efb3
      Matt Harbison authored
      There are only a handful of methods that access repo attributes that are applied
      in reposetup().  The `diff` test covers all of the commands that call
      scmutil.prefetchfiles().  Along the way, I saw that adding files and upgrading
      the repo format were also problems (also tested here).
      
      I don't think running `hg serve` through the commandserver is sane, but I
      conditionalized both the capabilities and the wsgirequest handler because it's
      trivially correct.  It doesn't look like there has ever been a caller of
      candownload(), so there's no test for that path.
      
      The upload case isn't testable, because uploadblobs() bails if there are no
      pointers.  The requirement should be added any time pointers are introduced, and
      that would force the extension to be loaded specifically for the repo.  This
      covers `debuglfsupload`, the pre-push hook (which isn't set until the repo is
      promoted to LFS), and uploadblobsfromrevs(), which can be called by other
      extensions.
      
      I think readfromstore() and writetostore() are only reachable as a flag
      processor for revlog.REVIDX_EXTSTORED, and a requirement is added as soon as
      that is seen, so I don't think those are a problem.
      3790efb3
  9. May 24, 2018
  10. May 18, 2018
  11. May 23, 2018
  12. May 04, 2018
  13. May 01, 2018
  14. May 21, 2018
  15. May 04, 2018
  16. May 15, 2018
  17. May 12, 2018
  18. May 11, 2018
  19. May 08, 2018
  20. May 05, 2018
  21. Dec 01, 2017
    • Gregory Szorc's avatar
      filelog: don't crash on invalid copy metadata (issue5748) · 6614cac5
      Gregory Szorc authored
      "copy" and "copyrev" are both supposed to appear next to each other.
      However, a user report demonstrated a crash that indicates that
      something in the wild is producing "copy" without "copyrev"
      (probably `hg convert`).
      
      While we should definitely fix the source of the bad metadata,
      the bad code causing the crash is already in the wild and who knows
      how many repositories are impacted. So let's be more defensive
      when accessing the file revision metadata.
  22. Apr 30, 2018
    • Gregory Szorc's avatar
      httppeer: detect redirect to URL without query string (issue5860) · 6169d95d
      Gregory Szorc authored
      197d10e157ce subtly changed the HTTP peer's handling of HTTP redirects.
      
      Before that changeset, we instantiated an HTTP peer instance and
      performed the capabilities lookup with that instance. The old code had
      the following relevant properties:
      
      1) The HTTP request layer would automatically follow HTTP redirects.
      2) An encountered HTTP redirect would update a peer instance variable
         pointing to the repo URL.
      3) The peer would automagically perform a "capabilities" command
         request if a caller requested capabilities but capabilities were
         not yet defined.
      
      The first HTTP request issued by a peer is for ?cmd=capabilities. If
      the server responds with an HTTP redirect to a ?cmd=capabilities URL,
      the HTTP request layer automatically followed it, retrieved a valid
      capabilities response, and the peer's base URL was updated
      automatically so subsequent requests used the proper URL. In other
      words, things "just worked."
      
      In the case where the server redirected to a URL without the
      ?cmd=capabilities query string, the HTTP request layer would follow
      the redirect and likely encounter HTML. The peer's base URL would be
      updated and the unexpected Content-Type would raise a RepoError. We
      would catch RepoError and immediately call between() (testing the case
      for pre 0.9.1 servers not supporting the "capabilities" command). e.g.
      
          try:
              inst._fetchcaps()
          except error.RepoError:
              inst.between([(nullid, nullid)])
      
      between() would eventually call into _callstream(). And _callstream()
      made a call to self.capable('httpheader'). capable() would call
      self.capabilities(), which would see that no capabilities were set
      (because HTML was returned for that request) and call the "capabilities"
      command to fetch capabilities. Because the base URL had been updated
      from the redirect, this 2nd "capabilities" command would succeed and
      the client would immediately call "between," which would also succeed.
      The legacy handshake succeeded. Only because "capabilities" was
      successfully executed as a side effect did the peer recognize that it
      was talking to a modern server. In other words, this all appeared to
      work accidentally.
      
      After 197d10e157ce, we stopped calling the "capabilities" command on
      the peer instance. Instead, we made the request via a low-level opener,
      detected the redirect as part of response handling code, and passed the
      redirected URL into the constructed peer instance.
      
      For cases where the redirected URL included the query string, this
      "just worked." But for cases where the redirected URL stripped the query
      string, we threw RepoError and because we removed the "between" handshake
      fallback, we fell through to the "is a static HTTP repo" check and
      performed an HTTP request for .hg/requires.
      
      While 197d10e157ce was marked as backwards incompatible, the only
      intended backwards incompatible behavior was not performing the
      "between" fallback. It was not realized that the "between" command
      had the side-effect of recovering from an errant redirect that
      dropped the query string.
      
      This commit restores the previous behavior and allows clients to
      handle a redirect that drops the query string. In the case where
      the request is redirected and the query string is dropped, we raise
      a special case of RepoError. We then catch this special exception in
      the handshake code and perform another "capabilities" request against
      the redirected URL. If that works, all is well. Otherwise, we fall back
      to the "is a static HTTP repo" check.
      
      The new code is arguably better than before 197d10e157ce, as it is
      explicit about the expected behavior and we avoid performing a
      "between" request, saving a server round trip.
      
      Differential Revision: https://phab.mercurial-scm.org/D3433
      6169d95d
  23. May 03, 2018
Loading