Skip to content
Snippets Groups Projects
  • Brodie Rao's avatar
    02990e22150b
    tests: require regexes in unified tests to be marked with " (re)" · 02990e22150b
    Brodie Rao authored
    Consider this test:
    
      $ hg glog --template '{rev}:{node|short} "{desc}"\n'
      @  2:20c4f79fd7ac "3"
      |
      | o  1:38f24201dcab "2"
      |/
      o  0:2a18120dc1c9 "1"
    
    Because each line beginning with "|" can be compiled as a regular
    expression (equivalent to ".*|"), they will match any output.
    
    Similarly:
    
      $ echo foo
    
    
    The blank output line can be compiled as a regular expression and will
    also match any output.
    
    With this patch, none of the above output lines will be matched as
    regular expressions. A line must end in " (re)" in order to be matched
    as one.
    
    Lines are still matched literally first, so the following will pass:
    
      $ echo 'foo (re)'
      foo (re)
    02990e22150b
    History
    tests: require regexes in unified tests to be marked with " (re)"
    Brodie Rao authored
    Consider this test:
    
      $ hg glog --template '{rev}:{node|short} "{desc}"\n'
      @  2:20c4f79fd7ac "3"
      |
      | o  1:38f24201dcab "2"
      |/
      o  0:2a18120dc1c9 "1"
    
    Because each line beginning with "|" can be compiled as a regular
    expression (equivalent to ".*|"), they will match any output.
    
    Similarly:
    
      $ echo foo
    
    
    The blank output line can be compiled as a regular expression and will
    also match any output.
    
    With this patch, none of the above output lines will be matched as
    regular expressions. A line must end in " (re)" in order to be matched
    as one.
    
    Lines are still matched literally first, so the following will pass:
    
      $ echo 'foo (re)'
      foo (re)
test-bad-pull.t 840 B