Skip to content
Snippets Groups Projects
  • Kyle Lippincott's avatar
    068307b6
    statprof: fix off-by-one-line error in output · 068307b6
    Kyle Lippincott authored
    martinvonz claims they thought that this was intentional, but couldn't remember
    the reasoning for it. I can't understand why it would be preferable, and I
    didn't see anything in the comments in the file about why this would be useful,
    so I'm hopefully not breaking anything by "fixing" it.
    
    ### Old output
    
    ```
    | 100.0%  0.01s  dispatch.py:    run               line 43:  dispatch.run()
    | 100.0%  0.01s  dispatch.py:    dispatch          line 115:  status = dispatch(req)
    | 100.0%  0.01s  dispatch.py:    _runcatch         line 266:  ret = _runcatch(req) or 0
    | 100.0%  0.01s  dispatch.py:    _callcatch        line 442:  return _callcatch(ui, _runc...
    | 100.0%  0.01s  scmutil.py:     callcatch         line 451:  return scmutil.callcatch(ui...
    | 100.0%  0.01s  dispatch.py:    _runcatchfunc     line 155:  return func()
    | 100.0%  0.01s  dispatch.py:    _dispatch         line 432:  return _dispatch(req)
    | 100.0%  0.01s  hg.py:          repository        line 1179:  repo = hg.repository(
    | 100.0%  0.01s  hg.py:          _peerorrepo       line 221:  peer = _peerorrepo(
    | 100.0%  0.01s  util.py:        __getattribute__  line 188:  obj = _peerlookup(path).ins...
    | 100.0%  0.01s  localrepo.py:   makelocalrepositoryline 3227:  return makelocalrepository(...
    | 100.0%  0.01s  localrepo.py:   __init__          line 683:  return cls(
    | 100.0%  0.01s  util.py:        __getattribute__  line 1262:  self._extrafilterid = repov...
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: exec_moduleline          245:  self.__spec__.loader.exec_m...
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: get_codeline       779:
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: path_statsline         868:
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: _path_statline         1012:
    ```
    
    ### New output
    
    ```
    | 100.0%  0.01s  hg:             <module>          line 43:  dispatch.run()
    | 100.0%  0.01s  dispatch.py:    run               line 115:  status = dispatch(req)
    | 100.0%  0.01s  dispatch.py:    dispatch          line 266:  ret = _runcatch(req) or 0
    | 100.0%  0.01s  dispatch.py:    _runcatch         line 442:  return _callcatch(ui, _runc...
    | 100.0%  0.01s  dispatch.py:    _callcatch        line 451:  return scmutil.callcatch(ui...
    | 100.0%  0.01s  scmutil.py:     callcatch         line 155:  return func()
    | 100.0%  0.01s  dispatch.py:    _runcatchfunc     line 432:  return _dispatch(req)
    | 100.0%  0.01s  dispatch.py:    _dispatch         line 1179:  repo = hg.repository(
    | 100.0%  0.01s  hg.py:          repository        line 221:  peer = _peerorrepo(
    | 100.0%  0.01s  hg.py:          _peerorrepo       line 188:  obj = _peerlookup(path).ins...
    | 100.0%  0.01s  localrepo.py:   instance          line 3227:  return makelocalrepository(...
    | 100.0%  0.01s  localrepo.py:   makelocalrepositoryline 683:  return cls(
    | 100.0%  0.01s  localrepo.py:   __init__          line 1262:  self._extrafilterid = repov...
    | 100.0%  0.01s  util.py:        __getattribute__  line 245:  self.__spec__.loader.exec_m...
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: exec_moduleline          779:
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: get_codeline       868:
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: path_statsline         1012:
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: _path_statline         87:
    ```
    
    Differential Revision: https://phab.mercurial-scm.org/D9510
    068307b6
    History
    statprof: fix off-by-one-line error in output
    Kyle Lippincott authored
    martinvonz claims they thought that this was intentional, but couldn't remember
    the reasoning for it. I can't understand why it would be preferable, and I
    didn't see anything in the comments in the file about why this would be useful,
    so I'm hopefully not breaking anything by "fixing" it.
    
    ### Old output
    
    ```
    | 100.0%  0.01s  dispatch.py:    run               line 43:  dispatch.run()
    | 100.0%  0.01s  dispatch.py:    dispatch          line 115:  status = dispatch(req)
    | 100.0%  0.01s  dispatch.py:    _runcatch         line 266:  ret = _runcatch(req) or 0
    | 100.0%  0.01s  dispatch.py:    _callcatch        line 442:  return _callcatch(ui, _runc...
    | 100.0%  0.01s  scmutil.py:     callcatch         line 451:  return scmutil.callcatch(ui...
    | 100.0%  0.01s  dispatch.py:    _runcatchfunc     line 155:  return func()
    | 100.0%  0.01s  dispatch.py:    _dispatch         line 432:  return _dispatch(req)
    | 100.0%  0.01s  hg.py:          repository        line 1179:  repo = hg.repository(
    | 100.0%  0.01s  hg.py:          _peerorrepo       line 221:  peer = _peerorrepo(
    | 100.0%  0.01s  util.py:        __getattribute__  line 188:  obj = _peerlookup(path).ins...
    | 100.0%  0.01s  localrepo.py:   makelocalrepositoryline 3227:  return makelocalrepository(...
    | 100.0%  0.01s  localrepo.py:   __init__          line 683:  return cls(
    | 100.0%  0.01s  util.py:        __getattribute__  line 1262:  self._extrafilterid = repov...
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: exec_moduleline          245:  self.__spec__.loader.exec_m...
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: get_codeline       779:
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: path_statsline         868:
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: _path_statline         1012:
    ```
    
    ### New output
    
    ```
    | 100.0%  0.01s  hg:             <module>          line 43:  dispatch.run()
    | 100.0%  0.01s  dispatch.py:    run               line 115:  status = dispatch(req)
    | 100.0%  0.01s  dispatch.py:    dispatch          line 266:  ret = _runcatch(req) or 0
    | 100.0%  0.01s  dispatch.py:    _runcatch         line 442:  return _callcatch(ui, _runc...
    | 100.0%  0.01s  dispatch.py:    _callcatch        line 451:  return scmutil.callcatch(ui...
    | 100.0%  0.01s  scmutil.py:     callcatch         line 155:  return func()
    | 100.0%  0.01s  dispatch.py:    _runcatchfunc     line 432:  return _dispatch(req)
    | 100.0%  0.01s  dispatch.py:    _dispatch         line 1179:  repo = hg.repository(
    | 100.0%  0.01s  hg.py:          repository        line 221:  peer = _peerorrepo(
    | 100.0%  0.01s  hg.py:          _peerorrepo       line 188:  obj = _peerlookup(path).ins...
    | 100.0%  0.01s  localrepo.py:   instance          line 3227:  return makelocalrepository(...
    | 100.0%  0.01s  localrepo.py:   makelocalrepositoryline 683:  return cls(
    | 100.0%  0.01s  localrepo.py:   __init__          line 1262:  self._extrafilterid = repov...
    | 100.0%  0.01s  util.py:        __getattribute__  line 245:  self.__spec__.loader.exec_m...
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: exec_moduleline          779:
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: get_codeline       868:
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: path_statsline         1012:
    | 100.0%  0.01s  <frozen importlib._bootstrap_external>: _path_statline         87:
    ```
    
    Differential Revision: https://phab.mercurial-scm.org/D9510