Skip to content
Snippets Groups Projects
  • Pierre-Yves David's avatar
    28dfb2df4ab9
    commit: use `dirstate.change_files` to scope the associated `addremove` · 28dfb2df4ab9
    Pierre-Yves David authored
    This was significantly more complicated than I expected, because multiple
    extensions get in the way.
    
    I introduced a context that lazily open the transaction and associated context
    to work around these complication. See the inline documentation for details.
    
    Introducing the wrapping transaction remove the need for dirstate-guard (one of
    the ultimate goal of all this), and slightly affect the result of a `hg
    rollback` after a `hg commit --addremove`. That last part is deemed fine. It
    aligns the behavior with what happens after a failed `hg commit --addremove` and
    nobody should be using `hg rollback` anyway.
    
    The small output change in the test come from the different transaction timing
    and fact the transaction now backup the dirstate before the addremove, which
    might mean "no file to backup" when the repository starts from an empty state.
    28dfb2df4ab9
    History
    commit: use `dirstate.change_files` to scope the associated `addremove`
    Pierre-Yves David authored
    This was significantly more complicated than I expected, because multiple
    extensions get in the way.
    
    I introduced a context that lazily open the transaction and associated context
    to work around these complication. See the inline documentation for details.
    
    Introducing the wrapping transaction remove the need for dirstate-guard (one of
    the ultimate goal of all this), and slightly affect the result of a `hg
    rollback` after a `hg commit --addremove`. That last part is deemed fine. It
    aligns the behavior with what happens after a failed `hg commit --addremove` and
    nobody should be using `hg rollback` anyway.
    
    The small output change in the test come from the different transaction timing
    and fact the transaction now backup the dirstate before the addremove, which
    might mean "no file to backup" when the repository starts from an empty state.